feat(workflows): add reusable promotion runtimes - #60
Conversation
6d8d754 to
e97a762
Compare
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
|
|
||
| **CI Status:** Pending — this workflow triggered on push to \`$BRANCH\`." | ||
|
|
||
| - name: Mark ready |
There was a problem hiding this comment.
WARNING: Draft PR immediately marked as ready for review
The workflow creates a draft PR (line 36: --draft) but the subsequent "Mark ready" step (line 50) calls gh pr ready to remove the draft status. This is contradictory: a draft PR signals that it is not yet ready for review, but the step immediately marks it as ready, defeating the purpose of the draft status.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| TOTAL_COMMITS=$(jq -r '.total_commits // 0' "$COMPARE_FILE") | ||
| if [ "$TOTAL_COMMITS" -gt 100 ]; then | ||
| LAST_PAGE=$(( (TOTAL_COMMITS + 99) / 100 )) | ||
| gh api "$COMPARE_URL?per_page=100&page=$LAST_PAGE" > "$COMPARE_FILE" |
There was a problem hiding this comment.
WARNING: Pagination fetches oldest commits instead of newest when >100 commits exist
When the compare API returns more than 100 commits, the code fetches the last page (page=$LAST_PAGE), which contains the oldest commits. The first page (fetched on line 42) already contains the newest commits, but it gets overwritten. The release PR body will then list the oldest commits rather than the most recent ones.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (4 files)
Fix these issues in Kilo Cloud Reviewed by ling-3.0-flash-free · Input: 254K · Output: 25.4K · Cached: 687K |
1 participant
Summary
Validation