Repository navigation
Harden scroll-mode keyboard suppression to prevent intermittent text echo - #12
Closed
0RuiAlvel0 with Copilot wants to merge 2 commits into
Closed
0RuiAlvel0 with Copilot wants to merge 2 commits into
0RuiAlvel0 with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: 0RuiAlvel0 <8639820+0RuiAlvel0@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix character echo suppression in scroll mode
Harden scroll-mode keyboard suppression to prevent intermittent text echo
Sep 11, 2026
Owner
|
nope, this screwed up the interaction. It was impossible to come out of scroll mode with esc - this issue needs more attention. Not merged, not accepted not even for further review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While scroll mode is active, some key events were occasionally falling through to the focused app, causing unintended character input (for example in editors). This change makes scroll-mode suppression deterministic by treating hook handling as fail-closed during that mode.
Input suppression behavior
TrayApplicationContext,HandleKeyboardHookKeyDownandHandleKeyboardHookKeyUpnow capture whether the app is inScrollModeat entry and always return handled when it is.false.Scope of change