refactor: more querybuilder public interface

Author: TheRustifyer

canyon_core/src/connection/clients/mssql.rs

@@ -130,7 +130,7 @@ impl DbConnection for SqlServerConnector {
             .map_err(From::from)
     }
 
-    async fn get_database_type(&self) -> Result<DatabaseType, Box<dyn Error + Send + Sync>> {
+    fn get_database_type(&self) -> Result<DatabaseType, Box<dyn Error + Send + Sync>> {
         Ok(DatabaseType::SqlServer)
     }
 }

canyon_core/src/connection/clients/mysql.rs

@@ -87,7 +87,7 @@ impl DbConnection for MySQLConnector {
         Ok(mysql_stmt.run(mysql_connection).await?.affected_rows())
     }
 
-    async fn get_database_type(&self) -> Result<DatabaseType, Box<dyn Error + Send + Sync>> {
+    fn get_database_type(&self) -> Result<DatabaseType, Box<dyn Error + Send + Sync>> {
         Ok(DatabaseType::MySQL)
     }
 }

canyon_core/src/connection/clients/postgresql.rs

@@ -110,7 +110,7 @@ impl DbConnection for PostgresConnector {
             .map_err(From::from)
     }
 
-    async fn get_database_type(&self) -> Result<DatabaseType, Box<dyn Error + Send + Sync>> {
+    fn get_database_type(&self) -> Result<DatabaseType, Box<dyn Error + Send + Sync>> {
         Ok(DatabaseType::PostgreSql)
     }
 }

canyon_core/src/connection/contracts/mod.rs

@@ -114,5 +114,5 @@ pub trait DbConnection {
     ///
     /// # Returns
     /// A `Result` containing the [`DatabaseType`] on success or an error on failure.
-    async fn get_database_type(&self) -> Result<DatabaseType, Box<dyn Error + Send + Sync>>;
+    fn get_database_type(&self) -> Result<DatabaseType, Box<dyn Error + Send + Sync>>;
 }

canyon_core/src/connection/datasources.rs

@@ -137,6 +137,7 @@ impl DatasourceConfig {
             DatabaseType::SqlServer => 1433,
             #[cfg(feature = "mysql")]
             DatabaseType::MySQL => 3306,
+            _ => todo!("Non legal port cfg"),
         })
     }
 }

canyon_core/src/connection/db_connector.rs

@@ -48,6 +48,8 @@ impl DatabaseConnector {
 
             #[cfg(feature = "mysql")]
             DatabaseType::MySQL => Ok(Self::MySQL(MySQLConnector::new(datasource).await?)),
+
+            DatabaseType::Deferred => panic!("Deferred connection"),
         }
     }
 

canyon_core/src/connection/impl_db_connection_macro.rs

@@ -104,7 +104,7 @@ macro_rules! impl_db_connection_for_db_connector {
                 }
             }
 
-            async fn get_database_type(&self) -> Result<DatabaseType, Box<dyn Error + Send + Sync>> {
+            fn get_database_type(&self) -> Result<DatabaseType, Box<dyn Error + Send + Sync>> {
                 Ok(self.get_db_type())
             }
         }
@@ -168,7 +168,7 @@ macro_rules! impl_db_connection_for_str {
                 conn.execute(stmt, params).await
             }
 
-            async fn get_database_type(
+            fn get_database_type(
                 &self,
             ) -> Result<
                 $crate::connection::database_type::DatabaseType,

canyon_core/src/connection/mod.rs

@@ -117,7 +117,7 @@ where
         self.lock().await.execute(stmt, params).await
     }
 
-    async fn get_database_type(&self) -> Result<DatabaseType, Box<dyn Error + Send + Sync>> {
+    fn get_database_type(&self) -> Result<DatabaseType, Box<dyn Error + Send + Sync>> {
         todo!()
     }
 }

canyon_core/src/query/operators.rs

@@ -67,6 +67,7 @@ impl Operator for Like {
             DatabaseType::SqlServer => "VARCHAR",
             #[cfg(feature = "mysql")]
             DatabaseType::MySQL => "CHAR",
+            _ => panic!("Provisional LIKE"),
         };
 
         match *self {

canyon_core/src/query/querybuilder/contracts/mod.rs

@@ -12,19 +12,23 @@ pub trait UpdateQueryBuilderOps<'a>: QueryBuilderOps<'a> {
     /// Creates an SQL `SET` clause by specifying the columns that must be updated in the sentence,
     /// but without adding any [`QueryParameter`] value to the internal querybuilder
     fn set(self, columns: &'a [String]) -> Result<Self, Box<dyn Error + Send + Sync + 'a>>
-          where Self: std::marker::Sized;
+          where Self: Sized;
 
     /// Similar to [`Self::set`] but storing the underlying update values for each column in the
     /// internal values collection of the [`crate::query::querybuilder::QueryBuilder`]
     fn set_with_values<Z, Q>(self, columns: &'a [(Z, Q)]) -> Result<Self, Box<dyn Error + Send + Sync + 'a>>
     where
         Z: FieldIdentifier,
         Q: QueryParameter,
-        Self: std::marker::Sized,
+        Self: Sized,
         Vec<&'a dyn QueryParameter>: Extend<&'a Q>;
 }
 
 pub trait SelectQueryBuilderOps<'a>: QueryBuilderOps<'a> {
+    /// Adds the column names that must be added to the query in order to retrieve the correct mapped fields
+    /// If this method isn't invoked, the querybuilder will create a SELECT * FROM query
+    fn with_columns(self, columns: &'a [String]) -> Self;
+    
     /// Adds a *LEFT JOIN* SQL statement to the underlying
     /// `Sql Statement` held by the [`QueryBuilder`], where:
     ///