fix: keep provider controls current across rerenders

Author: writingdeveloper

src/renderer/nextView.ts

@@ -94,7 +94,7 @@ function taskRow(it: TaskWithProject, now: number): HTMLElement {
   const open = createProviderOpenControl({
     path: projectPath,
     historyAgentIds: project?.agentIds ?? [],
-    liveAgentIds: liveProjectProviders(projectPath),
+    liveAgentIds: () => liveProjectProviders(projectPath),
     compact: true,
     onOpen: (intent) => openInTerminal([{
       ...intent, name: projectName, staleLevel: 'neutral', branch: null, dirty: 0,

src/renderer/projectsView.ts

@@ -93,7 +93,7 @@ function providerOpenControl(p: ProjectViewModel, compact = false): HTMLElement
   return createProviderOpenControl({
     path: p.path,
     historyAgentIds: p.agentIds,
-    liveAgentIds: liveProjectProviders(p.path),
+    liveAgentIds: () => liveProjectProviders(p.path),
     compact,
     onOpen: (intent) => openInTerminal([{
       ...intent, name: p.name, staleLevel: p.stale.level, branch: p.branch, dirty: p.uncommitted,

src/renderer/providerOpenControl.ts

@@ -7,7 +7,7 @@ import { createProviderLogo, providerName } from './providerLogo';
 export interface ProviderOpenControlOptions {
   path: string;
   historyAgentIds: readonly AgentId[];
-  liveAgentIds: readonly AgentId[];
+  liveAgentIds(): readonly AgentId[];
   compact?: boolean;
   onOpen(intent: ProjectOpenIntent): void;
 }
@@ -18,6 +18,15 @@ const outcomeKey: Record<ProviderOpenOutcome, string> = {
   new: 'open.status_new',
 };
 
+// One shared selection subscription updates only controls that are still in the document. Keeping
+// renderers in a WeakMap avoids retaining every control ever replaced by a view re-render.
+const primaryRenderers = new WeakMap<HTMLElement, () => void>();
+subscribeAgentSelection(() => {
+  for (const root of Array.from(document.querySelectorAll<HTMLElement>('.provider-open'))) {
+    primaryRenderers.get(root)?.();
+  }
+});
+
 /** One provider-aware Open control shared by project cards, project rows, and task rows. */
 export function createProviderOpenControl(opts: ProviderOpenControlOptions): HTMLElement {
   const root = document.createElement('span');
@@ -86,7 +95,7 @@ export function createProviderOpenControl(opts: ProviderOpenControlOptions): HTM
 
   const renderMenu = (): void => {
     menu.replaceChildren();
-    for (const option of providerOpenOptions(installedAgents(), selectedAgent(), opts.historyAgentIds, opts.liveAgentIds)) {
+    for (const option of providerOpenOptions(installedAgents(), selectedAgent(), opts.historyAgentIds, opts.liveAgentIds())) {
       const row = document.createElement('div'); row.className = 'provider-open-row'; row.setAttribute('role', 'none');
       const automatic = document.createElement('button');
       automatic.type = 'button'; automatic.className = 'provider-open-option'; automatic.setAttribute('role', 'menuitem');
@@ -145,8 +154,7 @@ export function createProviderOpenControl(opts: ProviderOpenControlOptions): HTM
   menu.addEventListener('keydown', onMenuKey);
 
   renderPrimary();
-  const unsubscribe = subscribeAgentSelection(() => {
-    if (!root.isConnected) { unsubscribe(); return; }
+  primaryRenderers.set(root, () => {
     renderPrimary();
     if (open) renderMenu();
   });