Skip to content

Commit 6a1dd63

Browse files
authored
Remove Biome (#973)
We switched to TypeScript Language Server so we don't need it anymore.
1 parent 3a8e52c commit 6a1dd63

9 files changed

Lines changed: 2 additions & 69 deletions

File tree

build-aux/modules/biome.json

Lines changed: 0 additions & 21 deletions
This file was deleted.

build-aux/re.sonny.Workbench.Devel.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
],
4040
"modules": [
4141
"modules/blueprint-compiler.json",
42-
"modules/biome.json",
4342
"modules/gst-plugin-gtk4.json",
4443
"modules/vte.json",
4544
"modules/libshumate.json",

build-aux/re.sonny.Workbench.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
],
4040
"modules": [
4141
"modules/blueprint-compiler.json",
42-
"modules/biome.json",
4342
"modules/gst-plugin-gtk4.json",
4443
"modules/vte.json",
4544
"modules/libshumate.json",

data/app.metainfo.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
<release version="46.2" date="2024-07-xx">
5656
<description translatable="no">
5757
<ul>
58-
<li>Update Biome to 1.8.3</li>
58+
<li>Replace Biome with TypeScript Language Server</li>
5959
<li>Update gst-plugin-gtk4 to 1.12.7</li>
6060
</ul>
6161
</description>

src/application.js

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -64,23 +64,7 @@ application.connect("open", (_self, files, hint) => {
6464
load().catch(console.error);
6565
});
6666

67-
let proc_biome;
68-
6967
application.connect("startup", () => {
70-
// biome lsp-proxy starts a background server
71-
// it does not get stopped and leaves a process hanging
72-
// so manage it manually instead
73-
// See https://github.com/workbenchdev/Workbench/issues/828
74-
const subprocess_launcher = Gio.SubprocessLauncher.new(
75-
Gio.SubprocessFlags.STDERR_SILENCE,
76-
);
77-
proc_biome = subprocess_launcher.spawnv([
78-
"biome",
79-
"__run_server",
80-
"--config-path",
81-
pkg.pkgdatadir,
82-
]);
83-
8468
Library({
8569
application,
8670
});
@@ -90,10 +74,6 @@ application.connect("startup", () => {
9074
restoreSessions().catch(console.error);
9175
});
9276

93-
application.connect("shutdown", () => {
94-
proc_biome?.force_exit();
95-
});
96-
9777
application.connect("activate", () => {
9878
if (application.is_remote) {
9979
bootstrap().catch(console.error);

src/langs/css/CssDocument.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export class CssDocument extends Document {
2525
},
2626
});
2727

28-
// Biome doesn't support diff - it just returns one edit
28+
// GTKCssLanguageServer doesn't support diff - it just returns one edit
2929
// we don't want to loose the cursor position so we use this
3030
const state = this.code_view.saveState();
3131
applyTextEdits(text_edits, this.buffer);

src/langs/javascript/JavaScriptDocument.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,6 @@ export class JavaScriptDocument extends Document {
2626
},
2727
});
2828

29-
// Biome doesn't support diff - it just returns one edit
30-
// we don't want to loose the cursor position so we use this
31-
const state = this.code_view.saveState();
3229
applyTextEdits(text_edits, this.buffer);
33-
await this.code_view.restoreState(state);
3430
}
3531
}

src/langs/javascript/biome.json

Lines changed: 0 additions & 19 deletions
This file was deleted.

src/meson.build

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ configure_file(
4747
)
4848

4949
install_data('langs/vala/workbench.vala', install_dir: pkgdatadir)
50-
install_data('langs/javascript/biome.json', install_dir: pkgdatadir)
5150
install_data('project-readme.md', install_dir: pkgdatadir)
5251
subdir('libworkbench')
5352
subdir('Previewer')

0 commit comments

Comments
 (0)