Skip to content

Commit 476f685

Browse files
committed
Fix verify_pss returning raw C code instead of boolean
1 parent f8f9698 commit 476f685

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

tests/test_ciphers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -456,14 +456,14 @@ def test_rsa_pss_sign_verify(rsa_private_pss, rsa_public_pss):
456456
signature = rsa_private_pss.sign_pss(plaintext)
457457

458458
assert 1024 / 8 == len(signature) == rsa_private_pss.output_size
459-
assert 0 == rsa_public_pss.verify_pss(plaintext, signature)
459+
assert rsa_public_pss.verify_pss(plaintext, signature) is True
460460

461461
# private object holds both private and public info, so it can also verify
462462
# using the known public key.
463463
signature = rsa_private_pss.sign_pss(plaintext)
464464

465465
assert 1024 / 8 == len(signature) == rsa_private_pss.output_size
466-
assert 0 == rsa_private_pss.verify_pss(plaintext, signature)
466+
assert rsa_private_pss.verify_pss(plaintext, signature) is True
467467

468468
def test_rsa_sign_verify_pem(rsa_private_pem, rsa_public_pem):
469469
plaintext = t2b("Everyone gets Friday off.")

wolfcrypt/ciphers.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -811,8 +811,10 @@ def verify_pss(self, plaintext, signature):
811811
ret = _lib.wc_RsaPSS_CheckPadding(digest, len(digest),
812812
verify, ret, self._hash_type)
813813

814-
return ret
814+
if ret < 0: # pragma: no cover
815+
raise WolfCryptError("PSS padding check error (%d)" % ret)
815816

817+
return ret == 0
816818

817819

818820
class RsaPrivate(RsaPublic):

0 commit comments

Comments
 (0)