Fix SHA1 hash error handling

LinuxJedi · LinuxJedi · commit 550a034927e7 · 2026-03-18T15:12:01.000Z
F-815
diff --git a/src/internal.c b/src/internal.c
@@ -9146,10 +9146,11 @@ static int GetSha1CheckValue(const byte* dataIn, int inLen, byte* dataOut,
     }
 
     ret = wc_Hash(WC_HASH_TYPE_SHA, dataIn, inLen, hash, WC_SHA_DIGEST_SIZE);
-    if (ret == 0) {
-        XMEMCPY(dataOut, hash, PKCS11_CHECK_VALUE_SIZE);
-        *outLen = PKCS11_CHECK_VALUE_SIZE;
+    if (ret != 0) {
+        return CKR_FUNCTION_FAILED;
     }
+    XMEMCPY(dataOut, hash, PKCS11_CHECK_VALUE_SIZE);
+    *outLen = PKCS11_CHECK_VALUE_SIZE;
 
     return CKR_OK;
 }

Original file line number	Diff line number	Diff line change
`@@ -9146,10 +9146,11 @@ static int GetSha1CheckValue(const byte* dataIn, int inLen, byte* dataOut,`
`9146`	`9146`	`}`
`9147`	`9147`
`9148`	`9148`	`ret = wc_Hash(WC_HASH_TYPE_SHA, dataIn, inLen, hash, WC_SHA_DIGEST_SIZE);`
`9149`		`- if (ret == 0) {`
`9150`		`- XMEMCPY(dataOut, hash, PKCS11_CHECK_VALUE_SIZE);`
`9151`		`- *outLen = PKCS11_CHECK_VALUE_SIZE;`
	`9149`	`+ if (ret != 0) {`
	`9150`	`+ return CKR_FUNCTION_FAILED;`
`9152`	`9151`	`}`
	`9152`	`+ XMEMCPY(dataOut, hash, PKCS11_CHECK_VALUE_SIZE);`
	`9153`	`+ *outLen = PKCS11_CHECK_VALUE_SIZE;`
`9153`	`9154`
`9154`	`9155`	`return CKR_OK;`
`9155`	`9156`	`}`