Fix things found in review

* `getVarLen` should be re-initialized before the second
`WP11_Object_GetAttr` call.

* Session leaks if `C_Login` fails.

Author: LinuxJedi

src/crypto.c

@@ -706,6 +706,7 @@ static CK_RV SetAttributeValue(WP11_Session* session, WP11_Object* obj,
         }
         /* Cannot change extractable from false to true */
         if (!newObject && attr->type == CKA_EXTRACTABLE) {
+            getVarLen = sizeof(getVar);
             rv = WP11_Object_GetAttr(obj, CKA_EXTRACTABLE, &getVar,
                                      &getVarLen);
             if (rv != CKR_OK)

tests/find_objects_null_template_test.c

@@ -197,8 +197,10 @@ static CK_RV pkcs11_open_session(CK_SESSION_HANDLE* session)
         return ret;
 
     ret = funcList->C_Login(*session, CKU_USER, userPin, userPinLen);
-    if (ret != CKR_OK)
+    if (ret != CKR_OK) {
+        funcList->C_CloseSession(*session);
         return ret;
+    }
 
     return CKR_OK;
 }