Fix sizeof-on-pointer warnings and add client-address deny test for DMA allow list

Author: jackctj117

test/wh_test_clientserver.c

@@ -351,6 +351,19 @@ static int _testDma(whServerContext* server, whClientContext* client)
     WH_TEST_ASSERT_RETURN(0 == memcmp(testMem.srvBufAllow, testMem.cliBuf,
                                       sizeof(testMem.srvBufAllow)));
 
+    /* Check that out-of-allowlist client addresses are rejected */
+    WH_TEST_ASSERT_RETURN(WH_ERROR_ACCESS == whServerDma_CopyFromClient(
+                                                  server, testMem.srvBufAllow,
+                                                  (uintptr_t)testMem.srvBufDeny,
+                                                  sizeof(testMem.srvBufAllow),
+                                                  (whServerDmaFlags){0}));
+    WH_TEST_ASSERT_RETURN(WH_ERROR_ACCESS ==
+                          whServerDma_CopyToClient(
+                              server, (uintptr_t)testMem.srvBufDeny,
+                              testMem.srvBufAllow,
+                              sizeof(testMem.srvBufAllow),
+                              (whServerDmaFlags){0}));
+
     /* Check that zero-sized copies fail, even from allowed addresses */
     WH_TEST_ASSERT_RETURN(WH_ERROR_BADARGS == whServerDma_CopyFromClient(
                                                   server, testMem.srvBufAllow,
@@ -1224,8 +1237,8 @@ int whTest_ClientServerClientConfig(whClientConfig* clientCfg)
 
         /* Prepare echo test */
         send_len =
-            snprintf(send_buffer, sizeof(send_buffer), "Request:%u", counter);
-        (void)snprintf(recv_buffer, sizeof(recv_buffer), "NOTHING RECEIVED");
+            snprintf(send_buffer, WOLFHSM_CFG_COMM_DATA_LEN, "Request:%u", counter);
+        (void)snprintf(recv_buffer, WOLFHSM_CFG_COMM_DATA_LEN, "NOTHING RECEIVED");
         recv_len = 0;
 
         WH_TEST_RETURN_ON_FAIL(ret = wh_Client_Echo(client, send_len, send_buffer, &recv_len, recv_buffer));
@@ -1284,8 +1297,8 @@ int whTest_ClientServerClientConfig(whClientConfig* clientCfg)
         whNvmId lastAvailObjects = 0;
 
         label_len = snprintf(label, sizeof(label), "Label:%d", id);
-        len = snprintf(send_buffer, sizeof(send_buffer), "Data:%d Counter:%d",
-                       id, counter);
+        len = snprintf(send_buffer, WOLFHSM_CFG_COMM_DATA_LEN,
+                       "Data:%d Counter:%d", id, counter);
 
         lastAvailObjects = avail_objects;
 
@@ -1323,7 +1336,7 @@ int whTest_ClientServerClientConfig(whClientConfig* clientCfg)
         WH_TEST_ASSERT_RETURN(server_rc == WH_ERROR_OK);
         WH_TEST_ASSERT_RETURN(gid == id);
 
-        memset(recv_buffer, 0, sizeof(recv_buffer));
+        memset(recv_buffer, 0, WOLFHSM_CFG_COMM_DATA_LEN);
         WH_TEST_RETURN_ON_FAIL(ret = wh_Client_NvmRead(client, id, 0, glen,
                                                        &server_rc, &rlen,
                                                        (uint8_t*)recv_buffer));