spelling fix, additional sanity checks

Author: JacobBarthelmeh

.github/workflows/build-and-test-clientonly.yml

@@ -85,9 +85,9 @@ jobs:
             make -j CLIENT_ONLY=1 TLS=1 SHE=1 DEBUG_VERBOSE=1 WOLFSSL_DIR=../wolfssl && make run
         fi
 
-    # Restart server with fresh state for AUTH test run, even with the serer not
-    # supporting AUTH and the client supporting AUTH -- the client should still
-    # be able to connect and run tests while not authenticated.
+    # Restart server with fresh state for AUTH test run, even with the server
+    # not supporting AUTH and the client supporting AUTH -- the client should
+    # still be able to connect and run tests while not authenticated.
     - name: Restart POSIX server for AUTH
       run: |
         kill $SERVER_PID || true

port/posix/posix_auth.c

@@ -64,6 +64,7 @@ int posixAuth_Init(void* context, const void* config)
     (void)context;
     (void)config;
 
+    memset(users, 0, sizeof(users));
     return WH_ERROR_OK;
 }
 
@@ -186,7 +187,7 @@ int posixAuth_Login(void* context, uint8_t client_id, whAuthMethod method,
     whAuthBase_User* current_user = NULL;
 
     if ((out_user_id == NULL) || (out_permissions == NULL) ||
-        (loggedIn == NULL)) {
+        (loggedIn == NULL) || (username == NULL)) {
         return WH_ERROR_BADARGS;
     }
 

src/wh_message_auth.c

@@ -70,6 +70,8 @@ int wh_MessageAuth_TranslateLoginRequest(
     if (src_header != dest_header) {
         memcpy(dest_header->username, src_header->username,
                sizeof(dest_header->username));
+        /* make sure the destination username is null terminated */
+        dest_header->username[sizeof(dest_header->username) - 1] = '\0';
     }
     WH_T16(magic, dest_header, src_header, auth_data_len);