remove debug printf's and make note for future logging location

Author: JacobBarthelmeh

src/wh_auth.c

@@ -160,12 +160,13 @@ int wh_Auth_CheckRequestAuthorization(whAuthContext* context, uint16_t group,
     uint16_t action)
 {
     uint16_t user_id = context->user.user_id;
+    int rc;
 
-    printf("In authorization check: User ID: %d, Group: %d, Action: %d\n",
-        user_id, group, action);
+    /* @TODO add logging call here and with resulting return value  */
 
-    return context->cb->CheckRequestAuthorization(context->context, user_id,
+    rc = context->cb->CheckRequestAuthorization(context->context, user_id,
         group, action);
+    return rc;
 }
 
 
@@ -175,9 +176,6 @@ int wh_Auth_CheckKeyAuthorization(whAuthContext* context, uint32_t key_id,
 {
     uint16_t user_id = context->user.user_id;
 
-    printf("In key authorization check: User ID: %d, Key ID: %d, Action: %d\n",
-        user_id, key_id, action);
-
     return context->cb->CheckKeyAuthorization(context->context, user_id, key_id,
         action);
 }

src/wh_auth_base.c

@@ -68,7 +68,6 @@ int wh_AuthBase_Init(void* context, const void *config)
     /* add a demo user with admin permissions */
     rc = wh_AuthBase_UserAdd(context, "admin", &out_user_id, permissions,
         WH_AUTH_METHOD_PIN, "1234", 4);
-    printf("Admin user added with ID: %d\n", out_user_id);
     return rc;
 }
 
@@ -215,22 +214,17 @@ int wh_AuthBase_CheckRequestAuthorization(void* context,
 {
     int rc;
 
-    printf("In authorization check: User ID: %d, Group: %d, Action: %d\n",
-        user_id, group, action);
-
     if (user_id == WH_USER_ID_INVALID) {
         /* allow user login request attempt */
         if (group == WH_MESSAGE_GROUP_AUTH) {
             if (action == WH_MESSAGE_AUTH_ACTION_LOGIN) {
                 rc = WH_ERROR_OK;
             }
             else {
-                printf("User does not have permissions for the action");
                 rc = WH_ERROR_ACCESS;
             }
         }
         else {
-            printf("No user associated with session");
             rc = WH_ERROR_OK; /*rc = WH_ERROR_ACCESS;*/
         }
     }
@@ -254,12 +248,10 @@ int wh_AuthBase_CheckRequestAuthorization(void* context,
                     rc = WH_ERROR_OK;
                 }
                 else {
-                    printf("User does not have permissions for the action");
                     rc = WH_ERROR_ACCESS;
                 }
             }
             else {
-                printf("User does not have permissions for the group");
                 rc = WH_ERROR_ACCESS;
             }
         }
@@ -278,9 +270,6 @@ int wh_AuthBase_CheckKeyAuthorization(void* context, uint16_t user_id,
     int i;
     whAuthBase_User* user;
 
-    printf("In key authorization check: User ID: %d, Key ID: %d, Action: %d\n",
-        user_id, key_id, action);
-
     if (user_id == WH_USER_ID_INVALID) {
         return WH_ERROR_ACCESS;
     }
@@ -303,10 +292,6 @@ int wh_AuthBase_CheckKeyAuthorization(void* context, uint16_t user_id,
         }
     }
 
-    if (rc != WH_ERROR_OK) {
-        printf("User does not have access to the key");
-    }
-
     (void)context;
     (void)action; /* Action could be used for future fine-grained key access control */
     return rc;