add client only tcp auth tests

Author: JacobBarthelmeh

examples/posix/wh_posix_server/Makefile

@@ -59,6 +59,12 @@ endif
 # Set to @ if you want to suppress command echo
 CMD_ECHO ?=
 
+# Add code coverage option
+ifeq ($(COVERAGE),1)
+    CFLAGS += --coverage
+    LDFLAGS += --coverage
+endif
+
 # Check if DEBUG is set to 1 and append debug flags
 ifeq ($(DEBUG),1)
 	DBGFLAGS = -ggdb -g3

src/wh_auth_base.c

@@ -377,10 +377,17 @@ int wh_AuthBase_UserAdd(void* context, const char* username,
 
 int wh_AuthBase_UserDelete(void* context, uint16_t current_user_id, uint16_t user_id)
 {
-    whAuthBase_User* user = &users[user_id - 1];
+    whAuthBase_User* user;
+
+    if (user_id == WH_USER_ID_INVALID || user_id >= WH_AUTH_BASE_MAX_USERS) {
+        return WH_ERROR_NOTFOUND;
+    }
+
+    user = &users[user_id - 1];
     if (user->user.user_id == WH_USER_ID_INVALID) {
         return WH_ERROR_NOTFOUND;
     }
+
     memset(user, 0, sizeof(whAuthBase_User));
     (void)context;
     (void)current_user_id;
@@ -390,7 +397,13 @@ int wh_AuthBase_UserDelete(void* context, uint16_t current_user_id, uint16_t use
 int wh_AuthBase_UserSetPermissions(void* context, uint16_t current_user_id,
     uint16_t user_id, whAuthPermissions permissions)
 {
-    whAuthBase_User* user = &users[user_id - 1];
+    whAuthBase_User* user;
+
+    if (user_id == WH_USER_ID_INVALID || user_id >= WH_AUTH_BASE_MAX_USERS) {
+        return WH_ERROR_NOTFOUND;
+    }
+
+    user = &users[user_id - 1];
     if (user->user.user_id == WH_USER_ID_INVALID) {
         return WH_ERROR_NOTFOUND;
     }
@@ -435,7 +448,7 @@ int wh_AuthBase_UserSetCredentials(void* context, uint16_t user_id,
     whAuthBase_User* user;
     int rc = WH_ERROR_OK;
 
-    if (user_id == WH_USER_ID_INVALID) {
+    if (user_id == WH_USER_ID_INVALID || user_id >= WH_AUTH_BASE_MAX_USERS) {
         return WH_ERROR_BADARGS;
     }
 
@@ -445,7 +458,6 @@ int wh_AuthBase_UserSetCredentials(void* context, uint16_t user_id,
     }
 
     user = &users[user_id - 1]; /* subtract 1 to get the index */
-    
     if (user->user.user_id == WH_USER_ID_INVALID) {
         return WH_ERROR_NOTFOUND;
     }

test/wh_test.c

@@ -89,7 +89,7 @@ int whTest_Unit(void)
     WH_TEST_ASSERT(0 == whTest_ClientServer());
 
     /* Auth tests */
-    WH_TEST_ASSERT(0 == whTest_Auth());
+    WH_TEST_ASSERT(0 == whTest_AuthMEM());
 
 #ifndef WOLFHSM_CFG_NO_CRYPTO
     /* Crypto Tests */
@@ -150,6 +150,8 @@ int whTest_ClientConfig(whClientConfig* clientCfg)
     WH_TEST_RETURN_ON_FAIL(whTest_WolfCryptTestCfg(clientCfg));
 #endif /* WOLFHSM_CFG_TEST_WOLFCRYPTTEST */
 
+    WH_TEST_RETURN_ON_FAIL(whTest_AuthTCP(clientCfg));
+
     return WH_ERROR_OK;
 }