Address code review

Author: julek-wolfssl

tests/hash/hash-test.py

@@ -61,6 +61,12 @@ def setUpClass(cls):
         if not os.path.isdir(CERTS_DIR):
             raise unittest.SkipTest("certs directory not found")
 
+        config_log = os.path.join(".", "config.log")
+        if os.path.isfile(config_log):
+            with open(config_log, "r") as f:
+                if "disable-filesystem" in f.read():
+                    raise unittest.SkipTest("filesystem support disabled")
+
     def test_md5(self):
         r = run_wolfssl("md5", CERT_FILE)
         self.assertEqual(r.returncode, 0, r.stderr)

tests/ocsp/ocsp-test.py

@@ -38,7 +38,7 @@ def _ocsp_supported(binary):
     try:
         r = subprocess.run([binary, "ocsp", "-help"],
                            capture_output=True, timeout=5)
-        return True
+        return r.returncode == 0
     except (FileNotFoundError, subprocess.TimeoutExpired):
         return False
 

tests/run_tests.py

@@ -36,7 +36,10 @@ def main():
     for test_file in sorted(glob.glob(pattern, recursive=True)):
         suite.addTests(load_tests_from_file(test_file))
 
-    runner = unittest.TextTestRunner(verbosity=2, durations=5)
+    kwargs = dict(verbosity=2)
+    if sys.version_info >= (3, 12):
+        kwargs["durations"] = 5
+    runner = unittest.TextTestRunner(**kwargs)
     result = runner.run(suite)
     sys.exit(0 if result.wasSuccessful() else 1)