Addressed Copilot review comments

miyazakh · miyazakh · commit e1ea92c4f913 · 2026-04-09T10:18:37.000+09:00
diff --git a/src/hash/clu_hash.c b/src/hash/clu_hash.c
@@ -121,8 +121,7 @@ int wolfCLU_hash(WOLFSSL_BIO* bioIn, WOLFSSL_BIO* bioOut, const char* alg,
     }
 #endif
 #ifndef NO_SHA
-    if (ret == WOLFCLU_SUCCESS && XSTRNCMP(alg, "sha", 3) == 0
-            && XSTRLEN(alg) == 3) {
+    if (ret == WOLFCLU_SUCCESS && XSTRCMP(alg, "sha") == 0) {
         ret = wc_ShaHash(input, inputSz, output);
     }
 #endif
diff --git a/src/hash/clu_hash_setup.c b/src/hash/clu_hash_setup.c
@@ -140,7 +140,7 @@ int wolfCLU_hashSetup(int argc, char** argv)
 #endif
 
 #ifndef NO_SHA
-    if ((XSTRNCMP(alg, "sha", 3) == 0) && (XSTRLEN(alg) == 3))
+    if (XSTRCMP(alg, "sha") == 0)
         size = WC_SHA_DIGEST_SIZE;
 #endif
 

Original file line number	Diff line number	Diff line change
`@@ -121,8 +121,7 @@ int wolfCLU_hash(WOLFSSL_BIO* bioIn, WOLFSSL_BIO* bioOut, const char* alg,`
`121`	`121`	`}`
`122`	`122`	`#endif`
`123`	`123`	`#ifndef NO_SHA`
`124`		`- if (ret == WOLFCLU_SUCCESS && XSTRNCMP(alg, "sha", 3) == 0`
`125`		`- && XSTRLEN(alg) == 3) {`
	`124`	`+ if (ret == WOLFCLU_SUCCESS && XSTRCMP(alg, "sha") == 0) {`
`126`	`125`	`ret = wc_ShaHash(input, inputSz, output);`
`127`	`126`	`}`
`128`	`127`	`#endif`