addressed copilot comments

Author: miyazakh

src/crypto/clu_crypto_setup.c

@@ -348,18 +348,24 @@ int wolfCLU_setup(int argc, char** argv, char action)
                     "-in flag was not set, please enter a string or"
                    " file name to be encrypted: ");
             if (fgets(inName, sizeof(inName), stdin) == NULL) {
-                /* Failed to read input, continue */
-                continue;
+                /* EOF or read error: cannot prompt further */
+                wolfCLU_LogError("failed to read input file name");
+                wolfCLU_freeBins(pwdKey, iv, key, NULL, NULL);
+                if (mode != NULL)
+                    XFREE(mode, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER);
+                return WOLFCLU_FATAL_ERROR;
             }
-            /* If no newline is present, the line was too long. */
+            /* If no newline is present, the line was too long: flush and
+             * re-prompt rather than proceeding with a truncated filename. */
             if (strchr(inName, '\n') == NULL) {
                 int ch;
                 do {
                     ch = getchar();
                 } while (ch != '\n' && ch != EOF);
-            } else {
-                inName[strcspn(inName, "\n")] = '\0';
+                wolfCLU_LogError("input too long, please try again");
+                continue;
             }
+            inName[strcspn(inName, "\n")] = '\0';
             /* Do not accept an empty string as valid input */
             if (inName[0] == '\0') {
                 continue;
@@ -415,16 +421,22 @@ int wolfCLU_setup(int argc, char** argv, char action)
                     WOLFCLU_LOG(WOLFCLU_L0,
                             "Please enter a name for the output file: ");
                     if (fgets(outNameEnc, sizeof(outNameEnc), stdin) == NULL) {
-                        continue;
+                        /* EOF or read error: cannot prompt further */
+                        wolfCLU_LogError("failed to read output file name");
+                        wolfCLU_freeBins(pwdKey, iv, key, NULL, NULL);
+                        if (mode != NULL)
+                            XFREE(mode, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER);
+                        return WOLFCLU_FATAL_ERROR;
                     }
                     if (strchr(outNameEnc, '\n') == NULL) {
                         int ch;
                         do {
                             ch = getchar();
                         } while (ch != '\n' && ch != EOF);
-                    } else {
-                        outNameEnc[strcspn(outNameEnc, "\n")] = '\0';
+                        wolfCLU_LogError("input too long, please try again");
+                        continue;
                     }
+                    outNameEnc[strcspn(outNameEnc, "\n")] = '\0';
                     if (outNameEnc[0] == '\0') {
                         continue;
                     }
@@ -451,16 +463,22 @@ int wolfCLU_setup(int argc, char** argv, char action)
                     WOLFCLU_LOG(WOLFCLU_L0,
                             "Please enter a name for the output file: ");
                     if (fgets(outNameDec, sizeof(outNameDec), stdin) == NULL) {
-                        continue;
+                        /* EOF or read error: cannot prompt further */
+                        wolfCLU_LogError("failed to read output file name");
+                        wolfCLU_freeBins(pwdKey, iv, key, NULL, NULL);
+                        if (mode != NULL)
+                            XFREE(mode, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER);
+                        return WOLFCLU_FATAL_ERROR;
                     }
                     if (strchr(outNameDec, '\n') == NULL) {
                         int ch;
                         do {
                             ch = getchar();
                         } while (ch != '\n' && ch != EOF);
-                    } else {
-                        outNameDec[strcspn(outNameDec, "\n")] = '\0';
+                        wolfCLU_LogError("input too long, please try again");
+                        continue;
                     }
+                    outNameDec[strcspn(outNameDec, "\n")] = '\0';
                     if (outNameDec[0] == '\0') {
                         continue;
                     }

tests/encrypt/enc-test.sh

@@ -187,7 +187,7 @@ rm -f test-enc.der
 
 # Regression tests for stack buffer overflow fix (scanf -> fgets)
 
-# Test: -in not provided, filename supplied via stdin (inName path, L344)
+# Test: -in not provided, filename supplied via stdin to exercise the inName Path
 printf "certs/crl.der\n" | ./wolfssl enc -aes-128-cbc -out test-stdin-in.enc -k "testpass" > /dev/null 2>&1
 if [ $? != 0 ]; then
     echo "Failed: enc with stdin input (no -in flag)"