Addressed review comments

Author: miyazakh

src/crypto/clu_crypto_setup.c

@@ -25,6 +25,35 @@
 
 #ifndef WOLFCLU_NO_FILESYSTEM
 
+/* Prompt for a filename on stdin with validation.
+ * Returns WOLFCLU_SUCCESS on success, WOLFCLU_FATAL_ERROR on EOF/read error.
+ * buf is filled with the stripped, non-empty filename on success. */
+static int wolfCLU_readFilename(char* buf, int bufSz, const char* prompt)
+{
+    while (1) {
+        WOLFCLU_LOG(WOLFCLU_L0, "%s", prompt);
+        if (fgets(buf, bufSz, stdin) == NULL) {
+            wolfCLU_LogError("failed to read file name");
+            return WOLFCLU_FATAL_ERROR;
+        }
+        /* If no newline, line was too long: flush remainder and re-prompt */
+        if (strchr(buf, '\n') == NULL) {
+            int ch;
+            do {
+                ch = getchar();
+            } while (ch != '\n' && ch != EOF);
+            wolfCLU_LogError("input too long, please try again");
+            continue;
+        }
+        buf[strcspn(buf, "\r\n")] = '\0';
+        if (buf[0] == '\0') {
+            wolfCLU_LogError("empty input, please enter a file name");
+            continue;
+        }
+        return WOLFCLU_SUCCESS;
+    }
+}
+
 static const struct option crypt_options[] = {
     {"-sha",       no_argument,       0, WOLFCLU_CERT_SHA   },
     {"-sha224",    no_argument,       0, WOLFCLU_CERT_SHA224},
@@ -342,38 +371,15 @@ int wolfCLU_setup(int argc, char** argv, char action)
     }
 
     if (inCheck == 0 && encCheck == 1) {
-        ret = 0;
-        while (ret == 0) {
-            WOLFCLU_LOG(WOLFCLU_L0,
-                    "-in flag was not set, please enter a string or"
-                   " file name to be encrypted: ");
-            if (fgets(inName, sizeof(inName), stdin) == NULL) {
-                /* EOF or read error: cannot prompt further */
-                wolfCLU_LogError("failed to read input file name");
-                wolfCLU_freeBins(pwdKey, iv, key, NULL, NULL);
-                if (mode != NULL)
-                    XFREE(mode, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER);
-                return WOLFCLU_FATAL_ERROR;
-            }
-            /* If no newline is present, the line was too long: flush and
-             * re-prompt rather than proceeding with a truncated filename. */
-            if (strchr(inName, '\n') == NULL) {
-                int ch;
-                do {
-                    ch = getchar();
-                } while (ch != '\n' && ch != EOF);
-                wolfCLU_LogError("input too long, please try again");
-                continue;
-            }
-            inName[strcspn(inName, "\r\n")] = '\0';
-            /* Do not accept an empty string as valid input */
-            if (inName[0] == '\0') {
-                wolfCLU_LogError("empty input, please enter a file name");
-                continue;
-            }
-            ret = 1;
+        ret = wolfCLU_readFilename(inName, sizeof(inName),
+                "-in flag was not set, please enter a string or"
+                " file name to be encrypted: ");
+        if (ret != WOLFCLU_SUCCESS) {
+            wolfCLU_freeBins(pwdKey, iv, key, NULL, NULL);
+            if (mode != NULL)
+                XFREE(mode, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER);
+            return WOLFCLU_FATAL_ERROR;
         }
-        in = inName;
         WOLFCLU_LOG(WOLFCLU_L0, "Encrypting :\"%s\"", inName);
         inCheck = 1;
     }
@@ -417,34 +423,15 @@ int wolfCLU_setup(int argc, char** argv, char action)
         }
         else {
             if (outCheck == 0) {
-                ret = 0;
-                while (ret == 0) {
-                    WOLFCLU_LOG(WOLFCLU_L0,
-                            "Please enter a name for the output file: ");
-                    if (fgets(outNameEnc, sizeof(outNameEnc), stdin) == NULL) {
-                        /* EOF or read error: cannot prompt further */
-                        wolfCLU_LogError("failed to read output file name");
-                        wolfCLU_freeBins(pwdKey, iv, key, NULL, NULL);
-                        if (mode != NULL)
-                            XFREE(mode, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER);
-                        return WOLFCLU_FATAL_ERROR;
-                    }
-                    if (strchr(outNameEnc, '\n') == NULL) {
-                        int ch;
-                        do {
-                            ch = getchar();
-                        } while (ch != '\n' && ch != EOF);
-                        wolfCLU_LogError("input too long, please try again");
-                        continue;
-                    }
-                    outNameEnc[strcspn(outNameEnc, "\r\n")] = '\0';
-                    if (outNameEnc[0] == '\0') {
-                        wolfCLU_LogError("empty input, please enter a file name");
-                        continue;
-                    }
-                    out = outNameEnc;
-                    ret = 1;
+                ret = wolfCLU_readFilename(outNameEnc, sizeof(outNameEnc),
+                        "Please enter a name for the output file: ");
+                if (ret != WOLFCLU_SUCCESS) {
+                    wolfCLU_freeBins(pwdKey, iv, key, NULL, NULL);
+                    if (mode != NULL)
+                        XFREE(mode, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER);
+                    return WOLFCLU_FATAL_ERROR;
                 }
+                out = outNameEnc;
             }
             ret = wolfCLU_encrypt(alg, mode, pwdKey, key, keySize, in, out,
                 iv, block, ivCheck, inputHex);
@@ -460,34 +447,15 @@ int wolfCLU_setup(int argc, char** argv, char action)
         }
         else {
             if (outCheck == 0) {
-                ret = 0;
-                while (ret == 0) {
-                    WOLFCLU_LOG(WOLFCLU_L0,
-                            "Please enter a name for the output file: ");
-                    if (fgets(outNameDec, sizeof(outNameDec), stdin) == NULL) {
-                        /* EOF or read error: cannot prompt further */
-                        wolfCLU_LogError("failed to read output file name");
-                        wolfCLU_freeBins(pwdKey, iv, key, NULL, NULL);
-                        if (mode != NULL)
-                            XFREE(mode, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER);
-                        return WOLFCLU_FATAL_ERROR;
-                    }
-                    if (strchr(outNameDec, '\n') == NULL) {
-                        int ch;
-                        do {
-                            ch = getchar();
-                        } while (ch != '\n' && ch != EOF);
-                        wolfCLU_LogError("input too long, please try again");
-                        continue;
-                    }
-                    outNameDec[strcspn(outNameDec, "\r\n")] = '\0';
-                    if (outNameDec[0] == '\0') {
-                        wolfCLU_LogError("empty input, please enter a file name");
-                        continue;
-                    }
-                    out = outNameDec;
-                    ret = 1;
+                ret = wolfCLU_readFilename(outNameDec, sizeof(outNameDec),
+                        "Please enter a name for the output file: ");
+                if (ret != WOLFCLU_SUCCESS) {
+                    wolfCLU_freeBins(pwdKey, iv, key, NULL, NULL);
+                    if (mode != NULL)
+                        XFREE(mode, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER);
+                    return WOLFCLU_FATAL_ERROR;
                 }
+                out = outNameDec;
             }
             ret = wolfCLU_decrypt(alg, mode, pwdKey, key, keySize, in, out,
                 iv, block, keyType);

tests/encrypt/enc-test.sh

@@ -295,5 +295,51 @@ if [ $? -eq 0 ]; then
     rm -f test-cam-empty.enc test-cam-empty.dec
 fi
 
+# Test: 'input too long' path — inName buffer overflow prevention
+# Pipe a 255-char line (no newline within fgets buffer), triggering the
+# strchr(buf,'\n')==NULL flush branch, then supply a valid filename.
+LONG_INPUT=$(printf '%255s' ' ')
+printf "%s\ncerts/crl.der\n" "$LONG_INPUT" | \
+    ./wolfssl enc -aes-128-cbc -out test-toolong-in.enc -k "testpass" > /dev/null 2>&1
+if [ $? != 0 ]; then
+    echo "Failed: enc should recover and accept filename after too-long input (-in path)"
+    exit 99
+fi
+./wolfssl enc -d -aes-128-cbc -in test-toolong-in.enc -out test-toolong-in.dec -k "testpass" > /dev/null 2>&1
+diff certs/crl.der test-toolong-in.dec > /dev/null 2>&1
+if [ $? != 0 ]; then
+    echo "Failed: enc/dec roundtrip mismatch after too-long re-prompt (-in path)"
+    exit 99
+fi
+rm -f test-toolong-in.enc test-toolong-in.dec
+
+# Test: 'input too long' path — outNameEnc/outNameDec (non-EVP path, Camellia)
+./wolfssl enc -camellia-128-cbc -in certs/crl.der -out test-cam-probe3.enc -k "testpass" > /dev/null 2>&1
+if [ $? -eq 0 ]; then
+    rm -f test-cam-probe3.enc
+
+    # outNameEnc: too-long input flushed, then valid output name accepted
+    printf "%s\ntest-cam-toolong.enc\n" "$LONG_INPUT" | \
+        ./wolfssl enc -camellia-128-cbc -in certs/crl.der -k "testpass" > /dev/null 2>&1
+    if [ $? != 0 ]; then
+        echo "Failed: Camellia enc should recover after too-long output name (outNameEnc)"
+        exit 99
+    fi
+
+    # outNameDec: too-long input flushed, then valid output name accepted
+    printf "%s\ntest-cam-toolong.dec\n" "$LONG_INPUT" | \
+        ./wolfssl enc -d -camellia-128-cbc -in test-cam-toolong.enc -k "testpass" > /dev/null 2>&1
+    if [ $? != 0 ]; then
+        echo "Failed: Camellia dec should recover after too-long output name (outNameDec)"
+        exit 99
+    fi
+    diff certs/crl.der test-cam-toolong.dec > /dev/null 2>&1
+    if [ $? != 0 ]; then
+        echo "Failed: enc/dec roundtrip mismatch after too-long re-prompt (outNameEnc/Dec)"
+        exit 99
+    fi
+    rm -f test-cam-toolong.enc test-cam-toolong.dec
+fi
+
 echo "Done"
 exit 0