Skip to content

Commit ef0ca14

Browse files
committed
Reduce splitCampaignsIntoChannelFolders to 1 loop run
- previously the campaigns array was checked 5 times, now the loop only runs 1 time
1 parent e33e4bd commit ef0ca14

1 file changed

Lines changed: 19 additions & 10 deletions

File tree

src/views/Overview.vue

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -56,19 +56,28 @@ export default defineComponent( {
5656
5757
const splitCampaignsIntoChannelFolders = ( overviewState, campaigns ) => {
5858
const desktopDERegex = new RegExp( /^\d{2}/ );
59-
overviewState.folders.desktop_de = campaigns.filter( ( { campaign } ) => campaign.match( desktopDERegex ) );
60-
6159
const mobileDERegex = new RegExp( /^mob-\d{2}/ );
62-
overviewState.folders.mobile_de = campaigns.filter( ( { campaign } ) => campaign.match( mobileDERegex ) );
63-
6460
const padDERegex = new RegExp( /^pad/ );
65-
overviewState.folders.pad_de = campaigns.filter( ( { campaign } ) => campaign.match( padDERegex ) );
66-
6761
const desktopENRegex = new RegExp( /^en/ );
68-
overviewState.folders.desktop_en = campaigns.filter( ( { campaign } ) => campaign.match( desktopENRegex ) );
69-
7062
const mobileENRegex = new RegExp( /^mob_en/ );
71-
overviewState.folders.mobile_en = campaigns.filter( ( { campaign } ) => campaign.match( mobileENRegex ) );
63+
64+
campaigns.forEach( ( campaign ) => {
65+
if( campaign.campaign.match( desktopDERegex ) ) {
66+
overviewState.folders.desktop_de.push( campaign );
67+
}
68+
else if ( campaign.campaign.match( mobileDERegex ) ) {
69+
overviewState.folders.mobile_de.push( campaign );
70+
}
71+
else if( campaign.campaign.match( padDERegex ) ) {
72+
overviewState.folders.pad_de.push( campaign );
73+
}
74+
else if( campaign.campaign.match( desktopENRegex ) ) {
75+
overviewState.folders.desktop_en.push( campaign );
76+
}
77+
else if( campaign.campaign.match( mobileENRegex ) ) {
78+
overviewState.folders.mobile_en.push( campaign );
79+
}
80+
} )
7281
}
7382
7483
const overviewState = reactive( overviewStateInit );
@@ -109,7 +118,7 @@ export default defineComponent( {
109118
.channelArea {
110119
width: 45%;
111120
margin: 0 0 0 35px;
112-
121+
113122
@media (min-width: 1100px) {
114123
width: 30%;
115124
}

0 commit comments

Comments
 (0)