Skip to content

Commit 6d2f15b

Browse files
committed
Declare compatibility with data-values/geo 2.0
1 parent e267bc2 commit 6d2f15b

2 files changed

Lines changed: 21 additions & 16 deletions

File tree

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,13 @@
2727
"irc": "irc://irc.freenode.net/wikidata"
2828
},
2929
"require": {
30-
"php": ">=5.5.0",
30+
"php": ">=5.5.9",
3131
"wikibase/data-model": "~7.0|~6.0|~5.0|~4.2",
3232
"serialization/serialization": "~3.1",
3333
"data-values/serialization": "~1.0"
3434
},
3535
"require-dev": {
36-
"data-values/geo": "~1.0|~0.1",
36+
"data-values/geo": "~2.0|~1.0|~0.1",
3737
"data-values/number": ">=0.1 <0.9",
3838
"data-values/time": "~0.2",
3939
"phpunit/phpunit": "~4.8"

tests/integration/EntityDeserializationCompatibilityTest.php

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,19 @@
33
namespace Tests\Wikibase\DataModel;
44

55
use DataValues\Deserializers\DataValueDeserializer;
6+
use DataValues\Geo\Values\GlobeCoordinateValue;
7+
use DataValues\QuantityValue;
8+
use DataValues\StringValue;
9+
use DataValues\TimeValue;
10+
use DataValues\UnknownValue;
611
use Deserializers\Deserializer;
712
use RecursiveDirectoryIterator;
813
use RecursiveIteratorIterator;
914
use SplFileInfo;
1015
use Wikibase\DataModel\DeserializerFactory;
1116
use Wikibase\DataModel\Entity\BasicEntityIdParser;
17+
use Wikibase\DataModel\Entity\EntityDocument;
18+
use Wikibase\DataModel\Entity\EntityIdValue;
1219

1320
/**
1421
* @license GPL-2.0+
@@ -23,16 +30,14 @@ class EntityDeserializationCompatibilityTest extends \PHPUnit_Framework_TestCase
2330

2431
protected function setUp() {
2532
$deserializerFactory = new DeserializerFactory(
26-
new DataValueDeserializer(
27-
array(
28-
'string' => 'DataValues\StringValue',
29-
'unknown' => 'DataValues\UnknownValue',
30-
'globecoordinate' => 'DataValues\GlobeCoordinateValue',
31-
'quantity' => 'DataValues\QuantityValue',
32-
'time' => 'DataValues\TimeValue',
33-
'wikibase-entityid' => 'Wikibase\DataModel\Entity\EntityIdValue',
34-
)
35-
),
33+
new DataValueDeserializer( [
34+
'string' => StringValue::class,
35+
'unknown' => UnknownValue::class,
36+
'globecoordinate' => GlobeCoordinateValue::class,
37+
'quantity' => QuantityValue::class,
38+
'time' => TimeValue::class,
39+
'wikibase-entityid' => EntityIdValue::class,
40+
] ),
3641
new BasicEntityIdParser()
3742
);
3843

@@ -46,7 +51,7 @@ public function testGivenEntitySerialization_entityIsReturned( $fileName, $seria
4651
$entity = $this->deserializer->deserialize( $serialization );
4752

4853
$this->assertInstanceOf(
49-
'Wikibase\DataModel\Entity\EntityDocument',
54+
EntityDocument::class,
5055
$entity,
5156
'Deserialization of ' . $fileName . ' should lead to an EntityDocument instance'
5257
);
@@ -57,17 +62,17 @@ public function entityProvider() {
5762
}
5863

5964
private function getEntitySerializationsFromDir( $dir ) {
60-
$argumentLists = array();
65+
$argumentLists = [];
6166

6267
/**
6368
* @var SplFileInfo $fileInfo
6469
*/
6570
foreach ( new RecursiveIteratorIterator( new RecursiveDirectoryIterator( $dir ) ) as $fileInfo ) {
6671
if ( $fileInfo->getExtension() === 'json' ) {
67-
$argumentLists[] = array(
72+
$argumentLists[] = [
6873
$fileInfo->getFilename(),
6974
json_decode( file_get_contents( $fileInfo->getPathname() ), true )
70-
);
75+
];
7176
}
7277
}
7378

0 commit comments

Comments
 (0)