Merge pull request #229 from wmde/arraysyntax

Switch all arrays to short syntax

Author: Ladsgroup

phpcs.xml

@@ -8,9 +8,5 @@
 		</properties>
 	</rule>
 
-	<rule ref="Generic.Arrays.DisallowLongArraySyntax.Found">
-		<exclude name="Generic.Arrays.DisallowLongArraySyntax.Found" />
-	</rule>
-
 	<file>.</file>
 </ruleset>

src/DeserializerFactory.php

@@ -59,10 +59,10 @@ public function __construct(
 	 * @return DispatchableDeserializer
 	 */
 	public function newEntityDeserializer() {
-		return new DispatchingDeserializer( array(
+		return new DispatchingDeserializer( [
 			$this->newItemDeserializer(),
 			$this->newPropertyDeserializer()
-		) );
+		] );
 	}
 
 	/**

src/Deserializers/AliasGroupListDeserializer.php

@@ -58,7 +58,7 @@ private function getDeserialized( array $serialization ) {
 	 * @return AliasGroup
 	 */
 	private function deserializeAliasGroup( array $serialization, $languageCode ) {
-		$aliases = array();
+		$aliases = [];
 
 		foreach ( $serialization as $aliasSerialization ) {
 			$this->assertIsValidAliasSerialization( $aliasSerialization, $languageCode );

src/Deserializers/SiteLinkDeserializer.php

@@ -58,11 +58,11 @@ private function getDeserialized( array $serialization ) {
 
 	private function getDeserializeBadges( array $serialization ) {
 		if ( !array_key_exists( 'badges', $serialization ) ) {
-			return array();
+			return [];
 		}
 		$this->assertBadgesIsArray( $serialization );
 
-		$badges = array();
+		$badges = [];
 		foreach ( $serialization['badges'] as $badgeSerialization ) {
 			$badges[] = $this->deserializeItemId( $badgeSerialization );
 		}

src/Deserializers/SnakDeserializer.php

@@ -64,7 +64,7 @@ private function hasSnakType( $serialization ) {
 	}
 
 	private function hasCorrectSnakType( $serialization ) {
-		return in_array( $serialization['snaktype'], array( 'novalue', 'somevalue', 'value' ) );
+		return in_array( $serialization['snaktype'], [ 'novalue', 'somevalue', 'value' ] );
 	}
 
 	/**

src/SerializerFactory.php

@@ -99,10 +99,10 @@ private function shouldSerializeReferenceSnaksWithHash() {
 	 * @return Serializer
 	 */
 	public function newEntitySerializer() {
-		return new DispatchingSerializer( array(
+		return new DispatchingSerializer( [
 			$this->newItemSerializer(),
 			$this->newPropertySerializer()
-		) );
+		] );
 	}
 
 	/**

src/Serializers/AliasGroupListSerializer.php

@@ -59,7 +59,7 @@ private function assertIsSerializerFor( $object ) {
 	 * @return array[]
 	 */
 	private function getSerialized( AliasGroupList $aliasGroupList ) {
-		$serialization = array();
+		$serialization = [];
 
 		foreach ( $aliasGroupList->getIterator() as $aliasGroup ) {
 			$serialization[$aliasGroup->getLanguageCode()] = $this->aliasGroupSerializer->serialize( $aliasGroup );

src/Serializers/AliasGroupSerializer.php

@@ -40,14 +40,14 @@ private function assertIsSerializerFor( $object ) {
 	 * @return array[]
 	 */
 	private function getSerialized( AliasGroup $aliasGroup ) {
-		$serialization = array();
+		$serialization = [];
 		$language = $aliasGroup->getLanguageCode();
 
 		foreach ( $aliasGroup->getAliases() as $value ) {
-			$result = array(
+			$result = [
 				'language' => $language,
 				'value' => $value
-			);
+			];
 
 			if ( $aliasGroup instanceof AliasGroupFallback ) {
 				$result['language'] = $aliasGroup->getActualLanguageCode();

src/Serializers/ItemSerializer.php

@@ -95,9 +95,9 @@ public function serialize( $object ) {
 	}
 
 	private function getSerialized( Item $item ) {
-		$serialization = array(
+		$serialization = [
 			'type' => $item->getType()
-		);
+		];
 
 		$this->addIdToSerialization( $item, $serialization );
 		$this->addTermsToSerialization( $item, $serialization );
@@ -128,7 +128,7 @@ private function addStatementListToSerialization( Item $item, array &$serializat
 	}
 
 	private function addSiteLinksToSerialization( Item $item, array &$serialization ) {
-		$serialization['sitelinks'] = array();
+		$serialization['sitelinks'] = [];
 
 		foreach ( $item->getSiteLinkList()->toArray() as $siteLink ) {
 			$serialization['sitelinks'][$siteLink->getSiteId()] = $this->siteLinkSerializer->serialize( $siteLink );

src/Serializers/PropertySerializer.php

@@ -79,10 +79,10 @@ public function serialize( $object ) {
 	}
 
 	private function getSerialized( Property $property ) {
-		$serialization = array(
+		$serialization = [
 			'type' => $property->getType(),
 			'datatype' => $property->getDataTypeId(),
-		);
+		];
 
 		$this->addIdToSerialization( $property, $serialization );
 		$this->addTermsToSerialization( $property, $serialization );