Skip to content

Commit fad0822

Browse files
committed
Remove redundant EntityIdValue test cases
1 parent c895742 commit fad0822

1 file changed

Lines changed: 9 additions & 11 deletions

File tree

tests/unit/Entity/EntityIdValueTest.php

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -39,22 +39,20 @@ public function testSerialzationRoundtrip( EntityIdValue $id ) {
3939
}
4040

4141
public function instanceProvider() {
42+
/** @var EntityId[] $ids */
4243
$ids = [
43-
'Q1' => new ItemId( 'Q1' ),
44-
'Q42' => new ItemId( 'Q42' ),
45-
'Q31337' => new ItemId( 'Q31337' ),
46-
'Q2147483647' => new ItemId( 'Q2147483647' ),
47-
'P1' => new PropertyId( 'P1' ),
48-
'P42' => new PropertyId( 'P42' ),
49-
'P31337' => new PropertyId( 'P31337' ),
50-
'X567' => new CustomEntityId( 'X567' ),
51-
'foo:P678' => new PropertyId( 'foo:P678' ),
44+
new ItemId( 'Q1' ),
45+
new ItemId( 'Q2147483647' ),
46+
new PropertyId( 'P1' ),
47+
new PropertyId( 'P31337' ),
48+
new CustomEntityId( 'X567' ),
49+
new PropertyId( 'foo:P678' ),
5250
];
5351

5452
$argLists = [];
5553

56-
foreach ( $ids as $k => $id ) {
57-
$argLists[$k] = [ new EntityIdValue( $id ) ];
54+
foreach ( $ids as $id ) {
55+
$argLists[$id->getSerialization()] = [ new EntityIdValue( $id ) ];
5856
}
5957

6058
return $argLists;

0 commit comments

Comments
 (0)