Add more tests

Author: thiemowmde

tests/unit/ReferenceListTest.php

@@ -157,6 +157,26 @@ public function testRemoveReference( ReferenceList $array ) {
 		$this->assertTrue( true );
 	}
 
+	public function testRemoveReferenceRemovesIdenticalObjects() {
+		$reference = new Reference( array( new PropertyNoValueSnak( 1 ) ) );
+		$references = new ReferenceList( array( $reference, $reference ) );
+
+		$references->removeReference( $reference );
+
+		$this->assertTrue( $references->isEmpty() );
+	}
+
+	public function testRemoveReferenceDoesNotRemoveCopies() {
+		$reference = new Reference( array( new PropertyNoValueSnak( 1 ) ) );
+		$references = new ReferenceList( array( $reference, clone $reference ) );
+
+		$references->removeReference( $reference );
+
+		$this->assertFalse( $references->isEmpty() );
+		$this->assertTrue( $references->hasReference( $reference ) );
+		$this->assertNotSame( $reference, $references->getReference( $reference->getHash() ) );
+	}
+
 	public function testAddReferenceOnEmptyList() {
 		$reference = new Reference( array( new PropertyNoValueSnak( 1 ) ) );
 
@@ -330,21 +350,36 @@ public function testRemoveReferenceHash( ReferenceList $references ) {
 		$this->assertEquals( 0, count( $references ) );
 	}
 
-	public function testRemoveReferenceHash_occurrencesOfSameObjectGetRemoved() {
-		$reference = new Reference( array( new PropertyNoValueSnak( 42 ) ) );
-		$references = new ReferenceList( array(
-			$reference,
-			clone $reference,
-			$reference
-		) );
+	public function testRemoveReferenceHashRemovesIdenticalObjects() {
+		$reference = new Reference( array( new PropertyNoValueSnak( 1 ) ) );
+		$references = new ReferenceList( array( $reference, $reference ) );
 
 		$references->removeReferenceHash( $reference->getHash() );
 
-		$this->assertTrue( $references->hasReferenceHash( $reference->getHash() ) );
-		$this->assertCount( 1, $references );
+		$this->assertTrue( $references->isEmpty() );
+	}
+
+	public function testRemoveReferenceHashDoesNotRemoveCopies() {
+		$reference = new Reference( array( new PropertyNoValueSnak( 1 ) ) );
+		$references = new ReferenceList( array( $reference, clone $reference ) );
+
+		$references->removeReferenceHash( $reference->getHash() );
+
+		$this->assertFalse( $references->isEmpty() );
+		$this->assertTrue( $references->hasReference( $reference ) );
 		$this->assertNotSame( $reference, $references->getReference( $reference->getHash() ) );
 	}
 
+	public function testRemoveReferenceHashUpdatesIndexes() {
+		$reference1 = new Reference( array( new PropertyNoValueSnak( 1 ) ) );
+		$reference2 = new Reference( array( new PropertyNoValueSnak( 2 ) ) );
+		$references = new ReferenceList( array( $reference1, $reference2 ) );
+
+		$references->removeReferenceHash( $reference1->getHash() );
+
+		$this->assertSame( 0, $references->indexOf( $reference2 ) );
+	}
+
 	public function testGivenOneSnak_addNewReferenceAddsSnak() {
 		$references = new ReferenceList();
 		$snak = new PropertyNoValueSnak( 1 );