Fix broken Item and Property::testSetEmptyAlias tests

Author: thiemowmde

tests/unit/Entity/ItemTest.php

@@ -490,29 +490,17 @@ public function testSetAliases( array $aliasesLists ) {
 		}
 	}
 
-	/**
-	 * @dataProvider aliasesProvider
-	 */
-	public function testSetEmptyAlias( array $aliasesLists ) {
-		$entity = $this->getNewEmpty();
-
-		foreach ( $aliasesLists as $langCode => $aliasesList ) {
-			foreach ( $aliasesList as $aliases ) {
-				$entity->setAliases( $langCode, $aliases );
-			}
-		}
-		$entity->setAliases( 'zh', [ 'wind', 'air', '', 'fire' ] );
-		$entity->setAliases( 'zu', [ '', '' ] );
-
-		foreach ( $aliasesLists as $langCode => $aliasesList ) {
-			$expected = array_values( array_unique( array_pop( $aliasesList ) ) );
-			asort( $aliasesList );
+	public function testSetEmptyAlias() {
+		$item = new Item();
 
-			$actual = $entity->getFingerprint()->getAliasGroup( $langCode )->getAliases();
-			asort( $actual );
+		$item->setAliases( 'en', [ 'wind', 'air', '', 'fire' ] );
+		$this->assertSame(
+			[ 'wind', 'air', 'fire' ],
+			$item->getAliasGroups()->getByLanguage( 'en' )->getAliases()
+		);
 
-			$this->assertEquals( $expected, $actual );
-		}
+		$item->setAliases( 'en', [ '', '' ] );
+		$this->assertFalse( $item->getAliasGroups()->hasGroupForLanguage( 'en' ) );
 	}
 
 	public function instanceProvider() {

tests/unit/Entity/PropertyTest.php

@@ -366,29 +366,17 @@ public function testSetAliases( array $aliasesLists ) {
 		}
 	}
 
-	/**
-	 * @dataProvider aliasesProvider
-	 */
-	public function testSetEmptyAlias( array $aliasesLists ) {
-		$entity = $this->getNewEmpty();
-
-		foreach ( $aliasesLists as $langCode => $aliasesList ) {
-			foreach ( $aliasesList as $aliases ) {
-				$entity->setAliases( $langCode, $aliases );
-			}
-		}
-		$entity->setAliases( 'zh', [ 'wind', 'air', '', 'fire' ] );
-		$entity->setAliases( 'zu', [ '', '' ] );
-
-		foreach ( $aliasesLists as $langCode => $aliasesList ) {
-			$expected = array_values( array_unique( array_pop( $aliasesList ) ) );
-			asort( $aliasesList );
+	public function testSetEmptyAlias() {
+		$property = Property::newFromType( 'string' );
 
-			$actual = $entity->getFingerprint()->getAliasGroup( $langCode )->getAliases();
-			asort( $actual );
+		$property->setAliases( 'en', [ 'wind', 'air', '', 'fire' ] );
+		$this->assertSame(
+			[ 'wind', 'air', 'fire' ],
+			$property->getAliasGroups()->getByLanguage( 'en' )->getAliases()
+		);
 
-			$this->assertEquals( $expected, $actual );
-		}
+		$property->setAliases( 'en', [ '', '' ] );
+		$this->assertFalse( $property->getAliasGroups()->hasGroupForLanguage( 'en' ) );
 	}
 
 	public function instanceProvider() {