Formally disallowed using colons/prefixes in the Item/Property ID

While no longer allowed/recognized, colon-separated
repository prefixes have still been formally allowed
in the Item or Property ID.
Also, if the ID was including a single leading
colon, it was quietly removed from the ID, and
accepted.

Those are no longer allowed, and no "normalization"
happens anymore.

Bug: T291823
Depends-On: I9839880d965051fa4b70986e744fe60d38f69a8a
Change-Id: I226cf78a82a26078519a2f89e72f845f04f650fe

Author: manicki

src/Entity/SerializableEntityId.php

@@ -22,7 +22,7 @@ abstract class SerializableEntityId implements EntityId {
 	 */
 	protected $localPart;
 
-	public const PATTERN = '/^:?(\w+:)*[^:]+\z/';
+	public const PATTERN = '/^[^:]+\z/';
 
 	/**
 	 * @param string $serialization

tests/unit/Entity/DispatchingEntityIdParserTest.php

@@ -63,6 +63,7 @@ public static function invalidIdSerializationProvider() {
 			[ ':Q1337' ],
 			[ 'foo:' ],
 			[ 'foo:bar:' ],
+			[ ':Q1337' ],
 			[ '::Q1337' ],
 			[ ':' ],
 			[ 'q:0' ],

tests/unit/Entity/EntityIdTest.php

@@ -152,28 +152,16 @@ public static function invalidJoinSerializationDataProvider() {
 		];
 	}
 
-	public function testGivenNotNormalizedSerialization_splitSerializationReturnsNormalizedParts() {
-		$this->assertSame( [ '', '', 'Q42' ], SerializableEntityId::splitSerialization( ':Q42' ) );
-	}
-
-	public static function localPartDataProvider() {
-		return [
-			[ 'Q42', 'Q42' ],
-			[ ':Q42', 'Q42' ],
-		];
-	}
-
-	/**
-	 * @dataProvider localPartDataProvider
-	 */
-	public function testGetLocalPart( $serialization, $localPart ) {
-		$id = new ItemId( $serialization );
-		$this->assertSame( $localPart, $id->getLocalPart() );
+	public function testGetLocalPart() {
+		$id = new ItemId( 'Q42' );
+		$this->assertSame( 'Q42', $id->getLocalPart() );
 	}
 
 	public static function invalidSerializationProvider() {
 		return [
+			[ 'foo:Q42' ],
 			[ 's p a c e s:Q42' ],
+			[ ':Q42' ],
 			[ '::Q42' ],
 			[ '' ],
 			[ ':' ],

tests/unit/Entity/ItemIdTest.php

@@ -36,7 +36,6 @@ public static function idSerializationProvider() {
 			[ 'q31337', 'Q31337' ],
 			[ 'Q31337', 'Q31337' ],
 			[ 'Q42', 'Q42' ],
-			[ ':Q42', 'Q42' ],
 			[ 'Q2147483647', 'Q2147483647' ],
 		];
 	}
@@ -71,6 +70,7 @@ public static function invalidIdSerializationProvider() {
 			// no longer supported (T291823, T338223)
 			[ 'foo:Q42', 'foo:Q42' ],
 			[ 'foo:bar:q42', 'foo:bar:Q42' ],
+			[ ':Q42', 'Q42' ],
 		];
 	}
 

tests/unit/Entity/NumericPropertyIdTest.php

@@ -35,7 +35,6 @@ public static function idSerializationProvider() {
 			[ 'p31337', 'P31337' ],
 			[ 'P31337', 'P31337' ],
 			[ 'P42', 'P42' ],
-			[ ':P42', 'P42' ],
 			[ 'P2147483647', 'P2147483647' ],
 		];
 	}
@@ -70,6 +69,7 @@ public static function invalidIdSerializationProvider() {
 			// no longer supported (T291823, T338223)
 			[ 'foo:P42', 'foo:P42' ],
 			[ 'foo:bar:p42', 'foo:bar:P42' ],
+			[ ':P42', 'P42' ],
 		];
 	}