Remove deprecated Item::getSiteLinks (#739)

This fixes #733.

Author: thiemowmde

src/Entity/Item.php

@@ -231,16 +231,6 @@ public function removeSiteLink( $siteId ) {
 		$this->siteLinks->removeLinkWithSiteId( $siteId );
 	}
 
-	/**
-	 * @deprecated since 0.8, use getSiteLinkList() instead,
-	 * @since 0.6
-	 *
-	 * @return SiteLink[]
-	 */
-	public function getSiteLinks() {
-		return array_values( iterator_to_array( $this->siteLinks ) );
-	}
-
 	/**
 	 * @deprecated since 0.8, use getSiteLinkList()->getBySiteId() instead.
 	 * @since 0.6

tests/unit/Entity/ItemTest.php

@@ -117,21 +117,6 @@ public function simpleSiteLinkProvider() {
 		return $argLists;
 	}
 
-	/**
-	 * @dataProvider simpleSiteLinksProvider
-	 */
-	public function testGetSiteLinks() {
-		$siteLinks = func_get_args();
-		$item = new Item();
-
-		foreach ( $siteLinks as $siteLink ) {
-			$item->getSiteLinkList()->addSiteLink( $siteLink );
-		}
-
-		$this->assertInternalType( 'array', $item->getSiteLinks() );
-		$this->assertEquals( $siteLinks, $item->getSiteLinks() );
-	}
-
 	public function simpleSiteLinksProvider() {
 		$argLists = [];