PHPMD: update config to ignore magic functions

toban · addshore · commit cd1faf237566 · 2020-05-26T15:33:38.000+01:00
Added __ to the PHPMD TooManyPublicMethods pattern.
diff --git a/phpmd.xml b/phpmd.xml
@@ -15,7 +15,7 @@
     </rule>
     <rule ref="rulesets/codesize.xml/TooManyPublicMethods">
         <properties>
-            <property name="ignorepattern" value="(^(set|get|test))i" />
+            <property name="ignorepattern" value="(^(set|get|test|__))i" />
             <property name="maxmethods" value="14" />
         </properties>
     </rule>
@@ -39,4 +39,4 @@
     <rule ref="rulesets/unusedcode.xml">
         <exclude name="UnusedLocalVariable" />
     </rule>
-</ruleset>
+</ruleset>
diff --git a/src/ReferenceList.php b/src/ReferenceList.php
@@ -26,7 +26,6 @@
  * @author Bene* < benestar.wikimedia@gmail.com >
  *
  * @phpcs:disable MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName
- * @SuppressWarnings(PHPMD.TooManyPublicMethods)
  */
 class ReferenceList implements Comparable, Countable, IteratorAggregate, Serializable {
 
diff --git a/src/Snak/SnakList.php b/src/Snak/SnakList.php
@@ -20,7 +20,6 @@
  * @author Addshore
  *
  * @phpcs:disable MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName
- * @SuppressWarnings(PHPMD.TooManyPublicMethods)
  */
 class SnakList extends ArrayObject implements Comparable, Hashable {
 

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,6 @@`
`26`	`26`	`* @author Bene* < benestar.wikimedia@gmail.com >`
`27`	`27`	`*`
`28`	`28`	`* @phpcs:disable MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName`
`29`		`- * @SuppressWarnings(PHPMD.TooManyPublicMethods)`
`30`	`29`	`*/`
`31`	`30`	`class ReferenceList implements Comparable, Countable, IteratorAggregate, Serializable {`
`32`	`31`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@`
`20`	`20`	`* @author Addshore`
`21`	`21`	`*`
`22`	`22`	`* @phpcs:disable MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName`
`23`		`- * @SuppressWarnings(PHPMD.TooManyPublicMethods)`
`24`	`23`	`*/`
`25`	`24`	`class SnakList extends ArrayObject implements Comparable, Hashable {`
`26`	`25`