Skip to content

Commit b97fe22

Browse files
committed
Merge pull request #643 from wmde/arrayHints
Add missing array type hints
2 parents 9299112 + 32b96be commit b97fe22

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

src/Snak/SnakList.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ public function getHash() {
109109
*
110110
* @since 0.5
111111
*/
112-
public function orderByProperty( $order = array() ) {
112+
public function orderByProperty( array $order = array() ) {
113113
$snaksByProperty = $this->getSnaksByProperty();
114114
$orderedProperties = array_unique( array_merge( $order, array_keys( $snaksByProperty ) ) );
115115

tests/unit/Snak/SnakListTest.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -273,11 +273,8 @@ public function orderByPropertyProvider() {
273273

274274
/**
275275
* @dataProvider orderByPropertyProvider
276-
* @param SnakList $snakList
277-
* @param SnakList $expected
278-
* @param string[] $order
279276
*/
280-
public function testOrderByProperty( SnakList $snakList, SnakList $expected, $order = array() ) {
277+
public function testOrderByProperty( SnakList $snakList, SnakList $expected, array $order = array() ) {
281278
$initialSnakList = new SnakList( array_values( iterator_to_array( $snakList ) ) );
282279

283280
$snakList->orderByProperty( $order );

0 commit comments

Comments
 (0)