Skip to content

Commit b5d881d

Browse files
thiemowmdeWMDE bot
authored andcommitted
Drop duplicate @dataProviders from tests
Same as I5aea363 in core. A test function can have multiple @dataProviders and a @dataProvider can be used by multiple test functions. Change-Id: I7b1b0efab33fdf699315f3fdad73789ce85c8e10
1 parent 528b399 commit b5d881d

2 files changed

Lines changed: 2 additions & 18 deletions

File tree

tests/unit/Entity/ItemTest.php

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -412,16 +412,8 @@ public function testSetLabel( $languageCode, $labelText, $moarText = 'ohi there'
412412
$this->assertSame( $moarText, $entity->getFingerprint()->getLabel( $languageCode )->getText() );
413413
}
414414

415-
public static function descriptionProvider() {
416-
return [
417-
[ 'en', 'spam' ],
418-
[ 'en', 'spam', 'spam' ],
419-
[ 'de', 'foo bar baz' ],
420-
];
421-
}
422-
423415
/**
424-
* @dataProvider descriptionProvider
416+
* @dataProvider labelProvider
425417
* @param string $languageCode
426418
* @param string $description
427419
* @param string $moarText

tests/unit/Entity/PropertyTest.php

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -291,16 +291,8 @@ public function testSetLabel( $languageCode, $labelText, $moarText = 'ohi there'
291291
$this->assertSame( $moarText, $entity->getFingerprint()->getLabel( $languageCode )->getText() );
292292
}
293293

294-
public static function descriptionProvider() {
295-
return [
296-
[ 'en', 'spam' ],
297-
[ 'en', 'spam', 'spam' ],
298-
[ 'de', 'foo bar baz' ],
299-
];
300-
}
301-
302294
/**
303-
* @dataProvider descriptionProvider
295+
* @dataProvider labelProvider
304296
* @param string $languageCode
305297
* @param string $description
306298
* @param string $moarText

0 commit comments

Comments
 (0)