Merge pull request #445 from wmde/minorSmell

Fix minor code smell issues

Author: Benestar

src/Claim/Claims.php

@@ -3,8 +3,6 @@
 namespace Wikibase\DataModel\Claim;
 
 use ArrayObject;
-use Comparable;
-use Hashable;
 use InvalidArgumentException;
 use Traversable;
 

src/Entity/Diff/PropertyDiffer.php

@@ -95,6 +95,7 @@ private function toDiffArray( Property $property ) {
 	public function getConstructionDiff( EntityDocument $entity ) {
 		$this->assertIsProperty( $entity );
 
+		/** @var Property $entity */
 		$diffOps = $this->diffPropertyArrays( array(), $this->toDiffArray( $entity ) );
 		$diffOps['claim'] = $this->statementListDiffer->getDiff( new StatementList(), $entity->getStatements() );
 
@@ -110,6 +111,7 @@ public function getConstructionDiff( EntityDocument $entity ) {
 	public function getDestructionDiff( EntityDocument $entity ) {
 		$this->assertIsProperty( $entity );
 
+		/** @var Property $entity */
 		$diffOps = $this->diffPropertyArrays( $this->toDiffArray( $entity ), array() );
 		$diffOps['claim'] = $this->statementListDiffer->getDiff( $entity->getStatements(), new StatementList() );
 

src/Statement/StatementByGuidMap.php

@@ -38,6 +38,7 @@ public function __construct( $statements = array() ) {
 	 * If the provided statement has a GUID not yet in the map, it will be appended to the map.
 	 * If the GUID is already in the map, the statement with this guid will be replaced.
 	 *
+	 * @throws InvalidArgumentException
 	 * @param Statement $statement
 	 */
 	public function addStatement( Statement $statement ) {

src/Statement/StatementList.php

@@ -287,7 +287,8 @@ public function isEmpty() {
 	 *
 	 * @param string|null $statementGuid
 	 *
-	 * @return int|bool
+	 * @throws InvalidArgumentException
+	 * @return int|bool Zero-based index or false if not found.
 	 */
 	public function getIndexByGuid( $statementGuid ) {
 		if ( !is_string( $statementGuid ) && !is_null( $statementGuid ) ) {

tests/unit/Entity/Diff/ItemDiffTest.php

@@ -204,16 +204,13 @@ public function testApply( Entity $a, Entity $b ) {
 		/**
 		 * @var Item $a
 		 * @var Item $b
+		 * @var SiteLink[] $siteLinks
 		 */
-
 		$siteLinks = array_merge(
-			$a->getSiteLinks(),
-			$b->getSiteLinks()
+			$a->getSiteLinkList()->toArray(),
+			$b->getSiteLinkList()->toArray()
 		);
 
-		/**
-		 * @var SiteLink $siteLink
-		 */
 		foreach ( $siteLinks as $siteLink ) {
 			$aLink = $a->getSiteLinkList()->getBySiteId( $siteLink->getSiteId() );
 			$bLink = $a->getSiteLinkList()->getBySiteId( $siteLink->getSiteId() );

tests/unit/Entity/EntityTest.php

@@ -8,7 +8,6 @@
 use Wikibase\DataModel\Entity\Diff\EntityDiff;
 use Wikibase\DataModel\Entity\Entity;
 use Wikibase\DataModel\Entity\Item;
-use Wikibase\DataModel\Statement\Statement;
 use Wikibase\DataModel\Term\AliasGroup;
 use Wikibase\DataModel\Term\AliasGroupList;
 use Wikibase\DataModel\Term\Fingerprint;

tests/unit/Entity/ItemTest.php

@@ -2,7 +2,6 @@
 
 namespace Wikibase\DataModel\Tests\Entity;
 
-use DataValues\StringValue;
 use Diff\DiffOp\Diff\Diff;
 use Diff\DiffOp\DiffOpAdd;
 use Diff\DiffOp\DiffOpChange;