Optimized DispatchingEntityIdParser (#764)

This made the function quite a bit faster:
14.48% 48797.778 817218 - Wikibase\DataModel\Entity\DispatchingEntityIdParser::parse
to
12.64% 42330.389 817218 - Wikibase\DataModel\Entity\DispatchingEntityIdParser::parse
when JSON-dumping 10,000 Wikidata entities.

Related to https://phabricator.wikimedia.org/T177486.

Author: mariushoch

src/Entity/DispatchingEntityIdParser.php

@@ -37,20 +37,19 @@ public function __construct( array $idBuilders ) {
 	 * @return EntityId
 	 */
 	public function parse( $idSerialization ) {
-		$this->assertIdIsString( $idSerialization );
-
-		if ( empty( $this->idBuilders ) ) {
+		if ( $this->idBuilders === [] ) {
 			throw new EntityIdParsingException( 'No id builders are configured' );
 		}
 
+		try {
+			list( , , $localId ) = EntityId::splitSerialization( $idSerialization );
+		} catch ( InvalidArgumentException $ex ) {
+			// EntityId::splitSerialization performs some sanity checks which
+			// might result in an exception. Should this happen, re-throw the exception message
+			throw new EntityIdParsingException( $ex->getMessage(), 0, $ex );
+		}
+
 		foreach ( $this->idBuilders as $idPattern => $idBuilder ) {
-			try {
-				list( , , $localId ) = EntityId::splitSerialization( $idSerialization );
-			} catch ( InvalidArgumentException $ex ) {
-				// EntityId::splitSerialization performs some sanity checks which
-				// might result in an exception. Should this happen, re-throw the exception message
-				throw new EntityIdParsingException( $ex->getMessage(), 0, $ex );
-			}
 			if ( preg_match( $idPattern, $localId ) ) {
 				return $this->buildId( $idBuilder, $idSerialization );
 			}
@@ -61,21 +60,6 @@ public function parse( $idSerialization ) {
 		);
 	}
 
-	/**
-	 * @param string $idSerialization
-	 *
-	 * @throws EntityIdParsingException
-	 */
-	private function assertIdIsString( $idSerialization ) {
-		if ( !is_string( $idSerialization ) ) {
-			throw new EntityIdParsingException(
-				'$idSerialization must be a string, got ' . ( is_object( $idSerialization )
-					? get_class( $idSerialization )
-					: getType( $idSerialization ) )
-			);
-		}
-	}
-
 	/**
 	 * @param callable $idBuilder
 	 * @param string $idSerialization