Merge pull request #368 from wmde/argList2x

Favor StatementList's argument list constructor

Author: JeroenDeDauw

tests/unit/Entity/Diff/EntityDiffTest.php

@@ -94,7 +94,7 @@ public function diffProvider() {
 
 		$statementListDiffer = new StatementListDiffer();
 		$diffOps['claim'] = $statementListDiffer->getDiff(
-			new StatementList( array( $statement ) ),
+			new StatementList( $statement ),
 			new StatementList()
 		);
 

tests/unit/Entity/ItemTest.php

@@ -674,7 +674,7 @@ public function testCanConstructWithStatementList() {
 		$statement = new Statement( new Claim( new PropertyNoValueSnak( 42 ) ) );
 		$statement->setGuid( 'meh' );
 
-		$statements = new StatementList( array( $statement ) );
+		$statements = new StatementList( $statement );
 
 		$item = new Item( null, null, null, $statements );
 

tests/unit/Statement/StatementListDifferTest.php

@@ -34,10 +34,10 @@ private function assertResultsInDiff( StatementList $fromStatements, StatementLi
 	}
 
 	public function testGivenTwoIdenticalLists_diffIsEmpty() {
-		$statements = new StatementList( array(
+		$statements = new StatementList(
 			$this->getNewStatement( 'zero', 'first' ),
-			$this->getNewStatement( 'one', 'second' ),
-		) );
+			$this->getNewStatement( 'one', 'second' )
+		);
 
 		$this->assertResultsInDiff( $statements, $statements, new Diff() );
 	}
@@ -49,16 +49,16 @@ private function getNewStatement( $guid, $hash ) {
 	}
 
 	public function testGivenToListWithExtraStatement_additionOperationInDiff() {
-		$fromStatements = new StatementList( array(
+		$fromStatements = new StatementList(
 			$this->getNewStatement( 'zero', 'first' ),
-			$this->getNewStatement( 'one', 'second' ),
-		) );
+			$this->getNewStatement( 'one', 'second' )
+		);
 
-		$toStatements = new StatementList( array(
+		$toStatements = new StatementList(
 			$this->getNewStatement( 'zero', 'first' ),
 			$this->getNewStatement( 'two', 'third' ),
-			$this->getNewStatement( 'one', 'second' ),
-		) );
+			$this->getNewStatement( 'one', 'second' )
+		);
 
 		$diff = new Diff( array(
 			'two' => new DiffOpAdd( $this->getNewStatement( 'two', 'third' ) ),
@@ -68,15 +68,15 @@ public function testGivenToListWithExtraStatement_additionOperationInDiff() {
 	}
 
 	public function testGivenToListWithLessStatements_removalOperationsInDiff() {
-		$fromStatements = new StatementList( array(
+		$fromStatements = new StatementList(
 			$this->getNewStatement( 'zero', 'first' ),
 			$this->getNewStatement( 'one', 'second' ),
-			$this->getNewStatement( 'two', 'third' ),
-		) );
+			$this->getNewStatement( 'two', 'third' )
+		);
 
-		$toStatements = new StatementList( array(
-			$this->getNewStatement( 'one', 'second' ),
-		) );
+		$toStatements = new StatementList(
+			$this->getNewStatement( 'one', 'second' )
+		);
 
 		$diff = new Diff( array(
 			'zero' => new DiffOpRemove( $this->getNewStatement( 'zero', 'first' ) ),
@@ -87,17 +87,17 @@ public function testGivenToListWithLessStatements_removalOperationsInDiff() {
 	}
 
 	public function testGivenListWithChangedStatements_changeOperationsInDiff() {
-		$fromStatements = new StatementList( array(
+		$fromStatements = new StatementList(
 			$this->getNewStatement( 'zero', 'first' ),
 			$this->getNewStatement( 'one', 'second' ),
-			$this->getNewStatement( 'two', 'third' ),
-		) );
+			$this->getNewStatement( 'two', 'third' )
+		);
 
-		$toStatements = new StatementList( array(
+		$toStatements = new StatementList(
 			$this->getNewStatement( 'zero', 'FIRST' ),
 			$this->getNewStatement( 'one', 'second' ),
-			$this->getNewStatement( 'two', 'THIRD' ),
-		) );
+			$this->getNewStatement( 'two', 'THIRD' )
+		);
 
 		$diff = new Diff( array(
 			'zero' => new DiffOpChange(