Update covers-validator and phpunit

Author: addshore

composer.json

@@ -32,9 +32,9 @@
 		"wikimedia/assert": "~0.2.2|~0.3.0|~0.4.0"
 	},
 	"require-dev": {
-		"ockcyp/covers-validator": "~0.5.0",
+		"ockcyp/covers-validator": "~1.1",
 		"phpmd/phpmd": "~2.6",
-		"phpunit/phpunit": "~5.7",
+		"phpunit/phpunit": "~8.0",
 		"wikibase/wikibase-codesniffer": "~1.1.0"
 	},
 	"autoload": {
@@ -58,7 +58,7 @@
 	"scripts": {
 		"test": [
 			"composer validate --no-interaction",
-			"vendor/bin/phpunit",
+			"phpunit",
 			"covers-validator"
 		],
 		"cs": [

tests/unit/Assert/RepositoryNameAssertTest.php

@@ -50,6 +50,7 @@ public function provideValidRepositoryNames() {
 	 */
 	public function testGivenValidValue_assertParameterIsValidRepositoryNamePasses( $value ) {
 		RepositoryNameAssert::assertParameterIsValidRepositoryName( $value, 'test' );
+		$this->assertTrue( true );
 	}
 
 	public function provideInvalidRepositoryNameIndexedArrays() {
@@ -84,6 +85,7 @@ public function provideValidRepositoryNameIndexedArrays() {
 	 */
 	public function testGivenValidValue_assertParameterKeysAreValidRepositoryNamesPasses( array $values ) {
 		RepositoryNameAssert::assertParameterKeysAreValidRepositoryNames( $values, 'test' );
+		$this->assertTrue( true );
 	}
 
 }

tests/unit/ReferenceListTest.php

@@ -146,6 +146,9 @@ public function testRemoveReference( ReferenceList $array ) {
 			$this->assertFalse( $array->hasReference( $element ) );
 			$this->assertSame( --$elementCount, count( $array ) );
 		}
+		if ( $elementCount === 0 ) {
+			$this->assertTrue( true );
+		}
 	}
 
 	public function testRemoveReferenceRemovesIdenticalObjects() {

tests/unit/SiteLinkListTest.php

@@ -347,7 +347,7 @@ public function testCanConstructWithIterable() {
 	}
 
 	public function testWhenProvidingNonIterable_constructorThrowsException() {
-		$this->setExpectedException( InvalidArgumentException::class );
+		$this->expectException( InvalidArgumentException::class );
 		new SiteLinkList( new SiteLink( 'enwiki', 'foo' ) );
 	}
 

tests/unit/Snak/SnakTest.php

@@ -14,10 +14,9 @@
  * @covers \Wikibase\DataModel\Snak\PropertyNoValueSnak
  * @covers \Wikibase\DataModel\Snak\PropertySomeValueSnak
  * @covers \Wikibase\DataModel\Snak\PropertyValueSnak
- * @covers \Wikibase\DataModel\Snak\Snak
  * @uses \Wikibase\DataModel\Snak\SnakObject
- * @uses DataValues\NumberValue
- * @uses DataValues\StringValue
+ * @uses \DataValues\NumberValue
+ * @uses \DataValues\StringValue
  * @uses \Wikibase\DataModel\Entity\EntityId
  * @uses \Wikibase\DataModel\Entity\PropertyId
  *

tests/unit/Term/TermListTest.php

@@ -468,21 +468,21 @@ public function testCanConstructWithIterables() {
 	}
 
 	public function testWhenProvidingNonTerms_constructorThrowsException() {
-		$this->setExpectedException( InvalidArgumentException::class );
+		$this->expectException( InvalidArgumentException::class );
 		new TermList( [ 'no-a-term' ] );
 	}
 
 	public function testWhenProvidingNonTerms_addAllThrowsException() {
 		$list = new TermList( [] );
 
-		$this->setExpectedException( InvalidArgumentException::class );
+		$this->expectException( InvalidArgumentException::class );
 		$list->addAll( [ 'no-a-term' ] );
 	}
 
 	public function testWhenProvidingNonIterable_addAllThrowsException() {
 		$list = new TermList( [] );
 
-		$this->setExpectedException( InvalidArgumentException::class );
+		$this->expectException( InvalidArgumentException::class );
 		$list->addAll( new Term( 'en', 'foo' ) );
 	}