Simplify and clean up AliasGroupListTest assertions

Author: thiemowmde

tests/unit/Term/AliasGroupListTest.php

@@ -48,7 +48,7 @@ public function testGivenTwoGroups_listContainsThem() {
 
 		$list = new AliasGroupList( $array );
 
-		$this->assertEquals( $array, iterator_to_array( $list ) );
+		$this->assertSame( $array, iterator_to_array( $list ) );
 	}
 
 	public function testGivenGroupsWithTheSameLanguage_onlyTheLastOnesAreRetained() {
@@ -85,7 +85,7 @@ public function testCanIterateOverList() {
 		 */
 		foreach ( $list as $key => $aliasGroup ) {
 			$this->assertEquals( $group, $aliasGroup );
-			$this->assertEquals( $aliasGroup->getLanguageCode(), $key );
+			$this->assertSame( $aliasGroup->getLanguageCode(), $key );
 		}
 	}
 
@@ -159,7 +159,7 @@ public function testGivenSetLanguage_removeByLanguageRemovesIt() {
 
 		$list->removeByLanguage( 'en' );
 
-		$this->assertEquals( new AliasGroupList(), $list );
+		$this->assertTrue( $list->isEmpty() );
 	}
 
 	/**
@@ -172,33 +172,24 @@ public function testGivenInvalidLanguageCode_removeByLanguageIsNoOp( $languageCo
 	}
 
 	public function testGivenEmptyGroups_constructorRemovesThem() {
-		$enGroup = new AliasGroup( 'en', [ 'foo' ] );
-
 		$list = new AliasGroupList( [
 			new AliasGroup( 'de' ),
-			$enGroup,
-			new AliasGroup( 'en' ),
-			new AliasGroup( 'nl' ),
-		] );
-
-		$expectedList = new AliasGroupList( [
+			new AliasGroup( 'en', [ 'foo' ] ),
 			new AliasGroup( 'en' ),
 		] );
 
-		$this->assertEquals( $expectedList, $list );
+		$this->assertTrue( $list->isEmpty() );
 	}
 
 	public function testGivenEmptyGroup_setGroupRemovesGroup() {
 		$list = new AliasGroupList( [
 			new AliasGroup( 'en', [ 'foo' ] ),
 		] );
 
-		$expectedList = new AliasGroupList();
-
 		$list->setGroup( new AliasGroup( 'en' ) );
 		$list->setGroup( new AliasGroup( 'de' ) );
 
-		$this->assertEquals( $expectedList, $list );
+		$this->assertEquals( new AliasGroupList(), $list );
 	}
 
 	public function testEmptyListEqualsEmptyList() {
@@ -333,7 +324,7 @@ public function testToArray() {
 
 		$list = new AliasGroupList( $array );
 
-		$this->assertEquals( $array, $list->toArray() );
+		$this->assertSame( $array, $list->toArray() );
 	}
 
 	public function testGivenEmptyList_getWithLanguagesReturnsEmptyList() {