Merge pull request #614 from wmde/entity-clear

Remove clear from Entity, Item and Property

Author: thiemowmde

src/Entity/Item.php

@@ -310,18 +310,6 @@ public function isEmpty() {
 			&& $this->siteLinks->isEmpty();
 	}
 
-	/**
-	 * Removes all content from the Item.
-	 * The id is not part of the content.
-	 *
-	 * @since 0.1
-	 */
-	public function clear() {
-		$this->fingerprint = new Fingerprint();
-		$this->siteLinks = new SiteLinkList();
-		$this->statements = new StatementList();
-	}
-
 	/**
 	 * @since 1.0
 	 *

src/Entity/Property.php

@@ -263,17 +263,6 @@ public function isEmpty() {
 			&& $this->statements->isEmpty();
 	}
 
-	/**
-	 * Removes all content from the Property.
-	 * The id and the type are not part of the content.
-	 *
-	 * @since 0.1
-	 */
-	public function clear() {
-		$this->fingerprint = new Fingerprint();
-		$this->statements = new StatementList();
-	}
-
 	/**
 	 * @since 1.1
 	 *

tests/unit/Entity/ItemTest.php

@@ -231,23 +231,6 @@ private function newStatement() {
 		return $statement;
 	}
 
-	public function testClearRemovesAllButId() {
-		$item = new Item( new ItemId( 'Q42' ) );
-		$item->getFingerprint()->setLabel( 'en', 'foo' );
-		$item->getSiteLinkList()->addNewSiteLink( 'enwiki', 'Foo' );
-		$item->getStatements()->addStatement( $this->newStatement() );
-
-		$item->clear();
-
-		$this->assertEquals( new ItemId( 'Q42' ), $item->getId() );
-		$this->assertTrue( $item->getFingerprint()->isEmpty() );
-		$this->assertTrue( $item->getLabels()->isEmpty() );
-		$this->assertTrue( $item->getDescriptions()->isEmpty() );
-		$this->assertTrue( $item->getAliasGroups()->isEmpty() );
-		$this->assertTrue( $item->getSiteLinkList()->isEmpty() );
-		$this->assertTrue( $item->getStatements()->isEmpty() );
-	}
-
 	public function testEmptyConstructor() {
 		$item = new Item();
 
@@ -282,13 +265,6 @@ public function testSetStatements() {
 		$this->assertTrue( $item->getStatements()->isEmpty() );
 	}
 
-	public function testGetStatementsReturnsCorrectTypeAfterClear() {
-		$item = new Item();
-		$item->clear();
-
-		$this->assertTrue( $item->getStatements()->isEmpty() );
-	}
-
 	public function equalsProvider() {
 		$firstItem = new Item();
 		$firstItem->getStatements()->addNewStatement( new PropertyNoValueSnak( 42 ) );

tests/unit/Entity/PropertyTest.php

@@ -112,18 +112,6 @@ public function testPropertyWithFingerprintIsNotEmpty() {
 		$this->assertFalse( $property->isEmpty() );
 	}
 
-	public function testClearRemovesAllButId() {
-		$property = Property::newFromType( 'string' );
-		$property->setId( 42 );
-		$property->getFingerprint()->setLabel( 'en', 'foo' );
-		$property->getStatements()->addNewStatement( new PropertyNoValueSnak( 1 ) );
-
-		$property->clear();
-
-		$this->assertEquals( new PropertyId( 'P42' ), $property->getId() );
-		$this->assertTrue( $property->isEmpty() );
-	}
-
 	public function testGetStatementsReturnsEmptyListForEmptyProperty() {
 		$property = Property::newFromType( 'string' );