Merge pull request #490 from wmde/getByPropertyId

Rename getWithPropertyId to getByPropertyId

Author: Benestar

RELEASE-NOTES.md

@@ -36,6 +36,7 @@ Other breaking changes:
 * Removed previously deprecated `Entity::getAllSnaks`, use `StatementList::getAllSnaks` instead
 * Removed previously deprecated `EntityId::getPrefixedId`, use `EntityId::getSerialization` instead
 * Removed previously deprecated `Property::newEmpty`, use `Property::newFromType` or `new Property()` instead
+* Renamed `StatementList::getWithPropertyId` to `StatementList::getByPropertyId`
 * `Reference` and `ReferenceList`s no longer can not be instantiated with `null`
 * Added `setId` method to `EntityDocument`
 

src/Statement/StatementList.php

@@ -140,13 +140,13 @@ public function getWithUniqueMainSnaks() {
 	}
 
 	/**
-	 * @since 2.3
+	 * @since 3.0
 	 *
 	 * @param PropertyId $id
 	 *
 	 * @return self
 	 */
-	public function getWithPropertyId( PropertyId $id ) {
+	public function getByPropertyId( PropertyId $id ) {
 		$statementList = new self();
 
 		foreach ( $this->statements as $statement ) {

tests/unit/Statement/StatementListTest.php

@@ -503,17 +503,17 @@ public function testGetMainSnaks() {
 		);
 	}
 
-	public function testGivenNotKnownPropertyId_getWithPropertyIdReturnsEmptyList() {
+	public function testGivenNotKnownPropertyId_getByPropertyIdReturnsEmptyList() {
 		$list = new StatementList();
 		$list->addNewStatement( new PropertyNoValueSnak( 42 ) );
 
 		$this->assertEquals(
 			new StatementList(),
-			$list->getWithPropertyId( new PropertyId( 'P2' ) )
+			$list->getByPropertyId( new PropertyId( 'P2' ) )
 		);
 	}
 
-	public function testGivenKnownPropertyId_getWithPropertyIdReturnsListWithOnlyMatchingStatements() {
+	public function testGivenKnownPropertyId_getByPropertyIdReturnsListWithOnlyMatchingStatements() {
 		$list = new StatementList();
 		$list->addNewStatement( new PropertyNoValueSnak( 42 ) );
 		$list->addNewStatement( new PropertyNoValueSnak( 9001 ) );
@@ -526,7 +526,7 @@ public function testGivenKnownPropertyId_getWithPropertyIdReturnsListWithOnlyMat
 
 		$this->assertEquals(
 			$expected,
-			$list->getWithPropertyId( new PropertyId( 'P42' ) )
+			$list->getByPropertyId( new PropertyId( 'P42' ) )
 		);
 	}