Merge pull request #462 from wmde/phpmd

Add PHPMD support

Author: JanZerebecki

composer.json

@@ -28,7 +28,8 @@
 		"data-values/data-values": "~0.1|~1.0"
 	},
 	"require-dev": {
-		"squizlabs/php_codesniffer": "~2.1"
+		"squizlabs/php_codesniffer": "~2.1",
+		"phpmd/phpmd": "~2.1"
 	},
 	"autoload": {
 		"files" : [
@@ -49,11 +50,18 @@
 			"phpunit"
 		],
 		"cs": [
-			"vendor/bin/phpcs src/* tests/* --standard=phpcs.xml --extensions=php -sp"
+			"composer phpcs",
+			"composer phpmd"
 		],
 		"ci": [
 			"composer test",
 			"composer cs"
+		],
+		"phpcs": [
+			"vendor/bin/phpcs src/* tests/* --standard=phpcs.xml --extensions=php -sp"
+		],
+		"phpmd": [
+			"vendor/bin/phpmd src/ text phpmd.xml"
 		]
 	}
 }

phpmd.xml

@@ -0,0 +1,30 @@
+<?xml version="1.0"?>
+<ruleset xmlns="http://pmd.sf.net/ruleset/1.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 http://pmd.sf.net/ruleset_xml_schema.xsd"
+         xsi:noNamespaceSchemaLocation=" http://pmd.sf.net/ruleset_xml_schema.xsd">
+
+    <rule ref="rulesets/codesize.xml">
+        <exclude name="TooManyMethods" />
+        <exclude name="ExcessiveClassComplexity" />
+    </rule>
+    <rule ref="rulesets/codesize.xml/TooManyMethods">
+        <properties>
+            <property name="maxmethods" value="20" />
+        </properties>
+    </rule>
+
+    <!-- todo: exclude the camel case method rule for the tests -->
+    <rule ref="rulesets/controversial.xml" />
+
+    <rule ref="rulesets/design.xml" />
+
+    <rule ref="rulesets/naming.xml">
+        <exclude name="ShortVariable" />
+        <exclude name="LongVariable" />
+    </rule>
+
+    <rule ref="rulesets/unusedcode.xml">
+        <exclude name="UnusedLocalVariable" />
+    </rule>
+</ruleset>

src/HashArray.php

@@ -69,12 +69,12 @@ abstract public function getObjectType();
 	 *
 	 * @param array|Traversable|null $input
 	 * @param int $flags
-	 * @param string $iterator_class
+	 * @param string $iteratorClass
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function __construct( $input = null, $flags = 0, $iterator_class = 'ArrayIterator' ) {
-		parent::__construct( array(), $flags, $iterator_class );
+	public function __construct( $input = null, $flags = 0, $iteratorClass = 'ArrayIterator' ) {
+		parent::__construct( array(), $flags, $iteratorClass );
 
 		if ( $input !== null ) {
 			if ( !is_array( $input ) && !( $input instanceof Traversable ) ) {