Remove getBestClaimPerProperty from ClaimList

The rank is a Statement concept, not a Claim one

Author: JeroenDeDauw

src/Claim/ClaimList.php

@@ -41,26 +41,6 @@ public function __construct( $claims = array() ) {
 		$this->claims = $claims;
 	}
 
-	/**
-	 * Returns the best claims per property.
-	 * The best claims are those with the highest rank for a particular property.
-	 * Deprecated ranks are never included.
-	 *
-	 * Caution: the ranking is done per property, not globally, as in the Claims class.
-	 *
-	 * @return self
-	 */
-	public function getBestClaimPerProperty() {
-		$claimList = new self();
-
-		foreach ( $this->getPropertyIds() as $propertyId ) {
-			$claims = new Claims( $this->claims );
-			$claimList->addClaims( $claims->getClaimsForProperty( $propertyId )->getBestClaims() );
-		}
-
-		return $claimList;
-	}
-
 	/**
 	 * Returns the property ids used by the claims.
 	 * The keys of the returned array hold the serializations of the property ids.
@@ -77,12 +57,6 @@ public function getPropertyIds() {
 		return $propertyIds;
 	}
 
-	private function addClaims( Claims $claims ) {
-		foreach ( $claims as $claim ) {
-			$this->addClaim( $claim );
-		}
-	}
-
 	public function addClaim( Claim $claim ) {
 		$this->claims[] = $claim;
 	}

tests/unit/Claim/ClaimListTest.php

@@ -89,34 +89,6 @@ public function testCanIterate() {
 		}
 	}
 
-	public function testGetBestClaimPerProperty() {
-		$list = new ClaimList( array(
-			$this->getStubClaim( 1, 'one', Claim::RANK_PREFERRED ),
-			$this->getStubClaim( 1, 'two', Claim::RANK_NORMAL ),
-			$this->getStubClaim( 1, 'three', Claim::RANK_PREFERRED ),
-
-			$this->getStubClaim( 2, 'four', Claim::RANK_DEPRECATED ),
-
-			$this->getStubClaim( 3, 'five', Claim::RANK_DEPRECATED ),
-			$this->getStubClaim( 3, 'six', Claim::RANK_NORMAL ),
-
-			$this->getStubClaim( 4, 'seven', Claim::RANK_PREFERRED ),
-			$this->getStubClaim( 4, 'eight', Claim::RANK_TRUTH ),
-		) );
-
-		$this->assertEquals(
-			array(
-				$this->getStubClaim( 1, 'one', Claim::RANK_PREFERRED ),
-				$this->getStubClaim( 1, 'three', Claim::RANK_PREFERRED ),
-
-				$this->getStubClaim( 3, 'six', Claim::RANK_NORMAL ),
-
-				$this->getStubClaim( 4, 'eight', Claim::RANK_TRUTH ),
-			),
-			$list->getBestClaimPerProperty()->toArray()
-		);
-	}
-
 	public function testGetUniqueMainSnaksReturnsListWithoutDuplicates() {
 		$list = new ClaimList( array(
 			$this->getClaimWithSnak( 1, 'foo' ),