Merge pull request #389 from wmde/double

JeroenDeDauw · JeroenDeDauw · commit 93d75185636e · 2015-03-05T17:23:24.000+01:00
Favor float over alias double
diff --git a/src/Entity/EntityIdValue.php b/src/Entity/EntityIdValue.php
@@ -42,10 +42,10 @@ public function serialize() {
 	 * though cannot be removed until we ditch the "numeric id" part
 	 * from the serialization.
 	 *
-	 * @return double Numeric id as a whole number. Can not be int because of 32-bit PHP.
+	 * @return float Numeric id as a whole number. Can not be int because of 32-bit PHP.
 	 */
 	protected function getNumericId() {
-		return doubleval( substr( $this->entityId->getSerialization(), 1 ) );
+		return floatval( substr( $this->entityId->getSerialization(), 1 ) );
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -42,10 +42,10 @@ public function serialize() {`
`42`	`42`	`* though cannot be removed until we ditch the "numeric id" part`
`43`	`43`	`* from the serialization.`
`44`	`44`	`*`
`45`		`- * @return double Numeric id as a whole number. Can not be int because of 32-bit PHP.`
	`45`	`+ * @return float Numeric id as a whole number. Can not be int because of 32-bit PHP.`
`46`	`46`	`*/`
`47`	`47`	`protected function getNumericId() {`
`48`		`- return doubleval( substr( $this->entityId->getSerialization(), 1 ) );`
	`48`	`+ return floatval( substr( $this->entityId->getSerialization(), 1 ) );`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`/**`