Merge pull request #167 from wmde/exceptions

Throw Exceptions for easier migration

Author: JeroenDeDauw

src/Entity/Entity.php

@@ -4,6 +4,7 @@
 
 use Diff\Patcher\MapPatcher;
 use InvalidArgumentException;
+use RuntimeException;
 use Wikibase\DataModel\Claim\Claim;
 use Wikibase\DataModel\Entity\Diff\EntityDiff;
 use Wikibase\DataModel\Entity\Diff\EntityDiffer;
@@ -358,8 +359,10 @@ public function copy() {
 	 * @param Claim $claim
 	 *
 	 * @throws InvalidArgumentException
+	 * @throws RuntimeException
 	 */
 	public function addClaim( Claim $claim ) {
+		throw new RuntimeException( 'Claims on entities are not supported any more.' );
 	}
 
 	/**

src/Entity/Item.php

@@ -10,12 +10,12 @@
 use OutOfBoundsException;
 use Wikibase\DataModel\Claim\Claim;
 use Wikibase\DataModel\Claim\Claims;
-use Wikibase\DataModel\Statement\Statement;
 use Wikibase\DataModel\Entity\Diff\EntityDiff;
 use Wikibase\DataModel\Entity\Diff\ItemDiff;
 use Wikibase\DataModel\SiteLink;
 use Wikibase\DataModel\SiteLinkList;
 use Wikibase\DataModel\Snak\Snak;
+use Wikibase\DataModel\Statement\Statement;
 use Wikibase\DataModel\Statement\StatementList;
 use Wikibase\DataModel\Term\Fingerprint;
 
@@ -326,7 +326,9 @@ function( Claim $firstClaim, Claim $secondClaim ) {
 	 * @throws InvalidArgumentException
 	 */
 	public function addClaim( Claim $statement ) {
-		if ( $statement->getGuid() === null ) {
+		if ( !( $statement instanceof Statement ) ) {
+			throw new InvalidArgumentException( 'Claims are not supported any more, use Statements.' );
+		} elseif ( $statement->getGuid() === null ) {
 			throw new InvalidArgumentException( 'Can\'t add a Claim without a GUID.' );
 		}