Removed Claims::getBestClaims

Author: JeroenDeDauw

RELEASE-NOTES.md

@@ -9,6 +9,7 @@
 	* `Statement::setClaim` and `Statement::getClaim` have been removed
 	* Removed `ClaimList`
 	* Removed `ClaimListAccess`
+* Removed `Claims::getBestClaims` (you can use `StatementList::getBestStatements` instead)
 
 ## Version 2.6.0 (2015-03-08)
 

src/Claim/Claims.php

@@ -421,30 +421,6 @@ public function getByRanks( array $ranks ) {
 		return $claims;
 	}
 
-	/**
-	 * Returns a new instance only containing the best claims (these are the highest
-	 * ranked claims, but never deprecated ones). This implementation ignores the properties
-	 * so you probably want to call Claims::getClaimsForProperty first or use
-	 * StatementList::getBestStatementPerProperty instead.
-	 *
-	 * @see Claims::getClaimsForProperty
-	 * @see StatementList::getBestStatementPerProperty
-	 *
-	 * @since 0.7
-	 *
-	 * @return Claims
-	 */
-	public function getBestClaims() {
-		$rank = Statement::RANK_PREFERRED;
-
-		do {
-			$claims = $this->getByRank( $rank );
-			$rank--;
-		} while ( $claims->isEmpty() && $rank > Statement::RANK_DEPRECATED );
-
-		return $claims;
-	}
-
 	/**
 	 * @see Comparable::equals
 	 *

tests/unit/Claim/ClaimsTest.php

@@ -621,54 +621,6 @@ public function testGetByRanks( Claims $input, $ranks, $expected ) {
 		$this->assertEquals( $input->getByRanks( $ranks ), $expected );
 	}
 
-	public function testGetBestClaimsEmpty() {
-		$claims = new Claims();
-		$this->assertEquals( $claims->getBestClaims(), new Claims() );
-	}
-
-	public function testGetBestClaimsOnlyOne() {
-		$statement = $this->makeStatement( new PropertyNoValueSnak( new PropertyId( 'P1' ) ) );
-		$statement->setRank( Statement::RANK_NORMAL );
-
-		$claims = new Claims( array( $statement ) );
-		$this->assertEquals( $claims->getBestClaims(), $claims );
-	}
-
-	public function testGetBestClaimsNoDeprecated() {
-		$statement = $this->makeStatement( new PropertyNoValueSnak( new PropertyId( 'P1' ) ) );
-		$statement->setRank( Statement::RANK_DEPRECATED );
-
-		$claims = new Claims( array( $statement ) );
-		$this->assertEquals( $claims->getBestClaims(), new Claims() );
-	}
-
-	public function testGetBestClaimsReturnOne() {
-		$s1 = $this->makeStatement( new PropertyNoValueSnak( new PropertyId( 'P1' ) ) );
-		$s1->setRank( Statement::RANK_DEPRECATED );
-
-		$s2 = $this->makeStatement( new PropertyNoValueSnak( new PropertyId( 'P2' ) ) );
-		$s2->setRank( Statement::RANK_NORMAL );
-
-		$claims = new Claims( array( $s1, $s2 ) );
-		$expected = new Claims( array( $s2 ) );
-		$this->assertEquals( $claims->getBestClaims(), $expected );
-	}
-
-	public function testGetBestClaimsReturnTwo() {
-		$s1 = $this->makeStatement( new PropertyNoValueSnak( new PropertyId( 'P1' ) ) );
-		$s1->setRank( Statement::RANK_NORMAL );
-
-		$s2 = $this->makeStatement( new PropertyNoValueSnak( new PropertyId( 'P2' ) ) );
-		$s2->setRank( Statement::RANK_PREFERRED );
-
-		$s3 = $this->makeStatement( new PropertyNoValueSnak( new PropertyId( 'P3' ) ) );
-		$s3->setRank( Statement::RANK_PREFERRED );
-
-		$claims = new Claims( array( $s3, $s1, $s2 ) );
-		$expected = new Claims( array( $s2, $s3 ) );
-		$this->assertEquals( $claims->getBestClaims(), $expected );
-	}
-
 	public function testEmptyListEqualsEmptyList() {
 		$list = new Claims( array() );
 		$this->assertTrue( $list->equals( clone $list ) );