Merge pull request #154 from wmde/ref

thiemowmde · thiemowmde · commit 7f98228397d7 · 2014-08-22T10:30:14.000+02:00
Improve Reference::equals
diff --git a/src/Reference.php b/src/Reference.php
@@ -83,9 +83,8 @@ public function getHash() {
 	 * @return boolean
 	 */
 	public function equals( $mixed ) {
-		return is_object( $mixed )
-			&& $mixed instanceof Reference
-			&& $this->getSnaks()->equals( $mixed->getSnaks() );
+		return $mixed instanceof self
+			&& $this->snaks->equals( $mixed->snaks );
 	}
 
 }

Original file line number	Diff line number	Diff line change
`@@ -83,9 +83,8 @@ public function getHash() {`
`83`	`83`	`* @return boolean`
`84`	`84`	`*/`
`85`	`85`	`public function equals( $mixed ) {`
`86`		`- return is_object( $mixed )`
`87`		`- && $mixed instanceof Reference`
`88`		`- && $this->getSnaks()->equals( $mixed->getSnaks() );`
	`86`	`+ return $mixed instanceof self`
	`87`	`+ && $this->snaks->equals( $mixed->snaks );`
`89`	`88`	`}`
`90`	`89`
`91`	`90`	`}`