Cleanup ReferenceList changes

Author: Benestar

RELEASE-NOTES.md

@@ -5,8 +5,9 @@
 * Removed `Claims` class (deprecated since 1.0)
 * Removed `getClaims` and `setClaims` from `Entity`, `Item` and `Property` (deprecated since 1.0)
 * Removed `ReferenceList::removeDuplicates`
-* `ReferenceList` no longer derives from `SplObjectStorage`, though still implements `Countable`
-    * `ReferenceList` now implements `IteratorAggregate` and has a `toArray` method
+* `ReferenceList` no longer derives from `SplObjectStorage`, though still implements `Countable` and `Traversable`
+    * `ReferenceList` now implements `IteratorAggregate`
+* `ReferenceList::addReference` now throws an `InvalidArgumentException` for negative indices
 * Removed `HashableObjectStorage`
 * `Entity` no longer implements `Comparable`
 * Added `EntityDocument::equals`

src/ReferenceList.php

@@ -126,7 +126,7 @@ public function hasReference( Reference $reference ) {
 	 */
 	public function indexOf( Reference $reference ) {
 		foreach ( $this->references as $index => $ref ) {
-			if ( $ref->equals( $reference ) ) {
+			if ( $ref === $reference ) {
 				return $index;
 			}
 		}
@@ -283,13 +283,4 @@ public function getIterator() {
 		return new ArrayIterator( $this->references );
 	}
 
-	/**
-	 * @since 5.0
-	 *
-	 * @return Reference[]
-	 */
-	public function toArray() {
-		return $this->references;
-	}
-
 }

tests/unit/ReferenceListTest.php

@@ -191,6 +191,17 @@ public function testAddReferenceAtIndexZero() {
 		$this->assertSameReferenceOrder( $expectedList, $references );
 	}
 
+	public function testAddReferenceAtNegativeIndex() {
+		$reference1 = new Reference( array( new PropertyNoValueSnak( 1 ) ) );
+		$reference2 = new Reference( array( new PropertyNoValueSnak( 2 ) ) );
+		$reference3 = new Reference( array( new PropertyNoValueSnak( 3 ) ) );
+
+		$references = new ReferenceList( array( $reference1, $reference2 ) );
+
+		$this->setExpectedException( 'InvalidArgumentException' );
+		$references->addReference( $reference3, -1 );
+	}
+
 	public function testGivenEmptyReference_addReferenceDoesNotAdd() {
 		$reference1 = new Reference( array( new PropertyNoValueSnak( 1 ) ) );
 		$reference2 = new Reference( array( new PropertyNoValueSnak( 2 ) ) );