Disallow periods in repository names (#737)

Periods would be confusing when entity ID is used in URIs/URLs
as they might be considered "separators" of parts of URL/URI.
Also periods are about to be used instead of colons in "chained"
entity IDs in cases where colons are not allowed (e.g. RDF).

Author: manicki

src/Assert/RepositoryNameAssert.php

@@ -28,7 +28,7 @@ class RepositoryNameAssert {
 	 */
 	public static function assertParameterIsValidRepositoryName( $value, $name ) {
 		if ( !self::isValidRepositoryName( $value ) ) {
-			throw new ParameterAssertionException( $name, 'must be a string not including colons' );
+			throw new ParameterAssertionException( $name, 'must be a string not including colons nor periods' );
 		}
 	}
 
@@ -51,7 +51,7 @@ public static function assertParameterKeysAreValidRepositoryNames( $values, $nam
 			if ( !self::isValidRepositoryName( $key ) ) {
 				throw new ParameterAssertionException(
 					"array_keys( $name )",
-					'must not contain strings including colons'
+					'must not contain strings including colons or periods'
 				);
 			}
 		}
@@ -62,7 +62,7 @@ public static function assertParameterKeysAreValidRepositoryNames( $values, $nam
 	 * @return bool
 	 */
 	private static function isValidRepositoryName( $value ) {
-		return is_string( $value ) && strpos( $value, ':' ) === false;
+		return is_string( $value ) && strpos( $value, ':' ) === false && strpos( $value, '.' ) === false;
 	}
 
 }

tests/unit/Assert/RepositoryNameAssertTest.php

@@ -18,6 +18,10 @@ public function provideInvalidRepositoryNames() {
 			[ 'foo:' ],
 			[ ':foo' ],
 			[ ':' ],
+			[ 'fo.o' ],
+			[ 'foo.' ],
+			[ '.foo' ],
+			[ '.' ],
 			[ 123 ],
 			[ null ],
 			[ false ],