Merge pull request #602 from wmde/snakListTests

Add more edge case tests for SnakList construction

Author: mariushoch

tests/unit/Snak/SnakListTest.php

@@ -91,9 +91,17 @@ public function invalidConstructorArgumentsProvider() {
 			array( $id1 ),
 			array( new PropertyNoValueSnak( $id1 ) ),
 			array( new PropertyValueSnak( $id1, new StringValue( 'a' ) ) ),
+			array( array( null ) ),
+			array( array( $id1 ) ),
+			array( array( new SnakList() ) ),
 		);
 	}
 
+	public function testGivenAssociativeArray_constructorPreservesArrayKeys() {
+		$snakList = new SnakList( array( 'key' => new PropertyNoValueSnak( 1 ) ) );
+		$this->assertSame( array( 'key' ), array_keys( iterator_to_array( $snakList ) ) );
+	}
+
 	/**
 	 * @dataProvider instanceProvider
 	 * @param SnakList $array