Remove all deprecated class aliases (#657)

* Remove all deprecated class aliases

* Skip AutoloadingAliasesTest

Author: thiemowmde

Aliases.php

@@ -5,26 +5,3 @@
 // Actual aliasing happens in the entry point using class_alias.
 
 namespace { throw new Exception( 'This code is not meant to be executed' ); }
-
-namespace Wikibase\DataModel\Claim {
-
-	/**
-	 * @deprecated since 3.0.0, use the base class instead.
-	 */
-	class Claim extends \Wikibase\DataModel\Statement\Statement {}
-
-	/**
-	 * @deprecated since 3.0.0, use the base class instead.
-	 */
-	class ClaimGuid extends \Wikibase\DataModel\Statement\StatementGuid {}
-
-}
-
-namespace Wikibase\DataModel {
-
-	/**
-	 * @deprecated since 3.0.0, use the base interface instead.
-	 */
-	interface StatementListProvider extends \Wikibase\DataModel\Statement\StatementListProvider {}
-
-}

WikibaseDataModel.php

@@ -12,8 +12,3 @@
 if ( defined( 'MEDIAWIKI' ) && function_exists( 'wfLoadExtension' ) ) {
 	wfLoadExtension( 'WikibaseDataModel', __DIR__ . '/mediawiki-extension.json' );
 }
-
-// Aliases introduced in 3.0.0
-class_alias( 'Wikibase\DataModel\Statement\Statement', 'Wikibase\DataModel\Claim\Claim' );
-class_alias( 'Wikibase\DataModel\Statement\StatementGuid', 'Wikibase\DataModel\Claim\ClaimGuid' );
-class_alias( 'Wikibase\DataModel\Statement\StatementListProvider', 'Wikibase\DataModel\StatementListProvider' );

tests/component/AutoloadingAliasesTest.php

@@ -11,7 +11,9 @@ class AutoloadingAliasesTest extends \PHPUnit_Framework_TestCase {
 	/**
 	 * @dataProvider oldNameProvider
 	 */
-	public function testAliasExists( $className ) {
+	public function testAliasExists( /* $className */ ) {
+		$this->markTestSkipped( 'No class aliases at the moment' );
+
 		$this->assertTrue(
 			class_exists( $className ) || interface_exists( $className ),
 			'Class name "' . $className . '" should still exist as alias'
@@ -21,9 +23,6 @@ class_exists( $className ) || interface_exists( $className ),
 	public function oldNameProvider() {
 		return [
 			// Full qualified aliases go here.
-			[ 'Wikibase\DataModel\Claim\Claim' ],
-			[ 'Wikibase\DataModel\Claim\ClaimGuid' ],
-			[ 'Wikibase\DataModel\StatementListProvider' ],
 		];
 	}
 

tests/unit/Entity/ItemTest.php

@@ -20,7 +20,6 @@
  * @covers Wikibase\DataModel\Entity\Item
  *
  * @group Wikibase
- * @group WikibaseItem
  * @group WikibaseDataModel
  *
  * @license GPL-2.0+

tests/unit/Entity/PropertyTest.php

@@ -20,7 +20,6 @@
  * @covers Wikibase\DataModel\Entity\Property
  *
  * @group Wikibase
- * @group WikibaseProperty
  * @group WikibaseDataModel
  *
  * @license GPL-2.0+

tests/unit/Statement/StatementByGuidMapTest.php

@@ -16,7 +16,7 @@
  */
 class StatementByGuidMapTest extends \PHPUnit_Framework_TestCase {
 
-	public function testGivenNotPresentGuid_hasClaimWithGuidReturnsFalse() {
+	public function testGivenNotPresentGuid_hasStatementWithGuidReturnsFalse() {
 		$statements = new StatementByGuidMap();
 
 		$this->assertFalse( $statements->hasStatementWithGuid( 'some guid' ) );
@@ -40,7 +40,7 @@ private function newStatement( $propertyId, $guid ) {
 	/**
 	 * @dataProvider nonStringProvider
 	 */
-	public function testGivenNonStringGuid_hasClaimWithGuidThrowsException( $nonString ) {
+	public function testGivenNonStringGuid_hasStatementWithGuidThrowsException( $nonString ) {
 		$statements = new StatementByGuidMap();
 
 		$this->setExpectedException( 'InvalidArgumentException' );

tests/unit/Statement/StatementTest.php

@@ -19,7 +19,6 @@
  *
  * @group Wikibase
  * @group WikibaseDataModel
- * @group WikibaseStatement
  *
  * @license GPL-2.0+
  * @author Jeroen De Dauw < jeroendedauw@gmail.com >
@@ -317,7 +316,7 @@ public function testGivenStatementWithDifferentSnakType_equalsReturnsFalse() {
 		$this->assertFalse( $statement->equals( new Statement( new PropertySomeValueSnak( 42 ) ) ) );
 	}
 
-	public function testStatementClaimWithDifferentQualifiers_equalsReturnsFalse() {
+	public function testStatementWithDifferentQualifiers_equalsReturnsFalse() {
 		$statement = new Statement(
 			new PropertyNoValueSnak( 42 ),
 			new SnakList( [
@@ -344,7 +343,7 @@ public function testGivenStatementWithDifferentGuids_equalsReturnsFalse() {
 		$this->assertFalse( $statement->equals( $differentStatement ) );
 	}
 
-	public function testStatementClaimWithDifferentReferences_equalsReturnsFalse() {
+	public function testStatementWithDifferentReferences_equalsReturnsFalse() {
 		$statement = new Statement(
 			new PropertyNoValueSnak( 42 ),
 			new SnakList(),