Stop Statement requiring a Claim

Author: thiemowmde

tests/unit/Entity/EntityTest.php

@@ -417,6 +417,31 @@ public function testHasClaims( Entity $entity ) {
 		$this->assertEquals( count( $entity->getClaims() ) !== 0, $has );
 	}
 
+	/**
+	 * Tests Entity::newClaim
+	 *
+	 * @dataProvider instanceProvider
+	 *
+	 * @param Entity $entity
+	 */
+	public function testNewClaim( Entity $entity ) {
+		if ( $entity->getId() === null ) {
+			$entity->setId( 50 );
+		}
+
+		$snak = new PropertyNoValueSnak( 42 );
+		$claim = new Statement( $snak );
+		$claim->setGuid( 'q42$foobarbaz' );
+
+		$this->assertInstanceOf( 'Wikibase\DataModel\Claim\Claim', $claim );
+
+		$this->assertTrue( $snak->equals( $claim->getMainSnak() ) );
+
+		$guid = $claim->getGuid();
+
+		$this->assertInternalType( 'string', $guid );
+	}
+
 	public function diffProvider() {
 		$argLists = array();
 

tests/unit/Entity/ItemTest.php

@@ -84,9 +84,9 @@ public function itemProvider() {
 		$items[] = $item;
 
 		$item = $item->copy();
-		$item->getStatements()->addNewStatement(
+		$item->getStatements()->addStatement( new Statement(
 			new PropertyNoValueSnak( new PropertyId( 'P42' ) )
-		);
+		) );
 		$items[] = $item;
 
 		$argLists = array();

tests/unit/Statement/StatementTest.php

@@ -46,9 +46,9 @@ public function testGetGuid( Statement $statement ) {
 	}
 
 	public function testSetAndGetMainSnak() {
-		$mainSnak = new PropertyNoValueSnak( new PropertyId( 'P42' ) );
-		$statement = new Statement( $mainSnak );
-		$this->assertSame( $mainSnak, $statement->getMainSnak() );
+		$snak = new PropertyNoValueSnak( new PropertyId( 'P42' ) );
+		$statement = new Statement( $snak );
+		$this->assertSame( $snak, $statement->getMainSnak() );
 	}
 
 	public function testSetAndGetQualifiers() {