Merge pull request #481 from wmde/setstatements

Add setStatements to StatementList

Author: JeroenDeDauw

RELEASE-NOTES.md

@@ -44,6 +44,7 @@ Other breaking changes:
 * Added `StatementByGuidMap`
 * Added `StatementList::getFirstStatementWithGuid`
 * Added `StatementList::removeStatementsWithGuid`
+* Added `StatementList::setStatements`
 * `ReferenceList::addNewReference` and `Statement::addNewReference` support an array of Snaks now
 * Added PHPMD support
 

src/Statement/StatementList.php

@@ -45,10 +45,22 @@ public function __construct( $statements = array() /*...*/ ) {
 			$statements = func_get_args();
 		}
 
+		$this->setStatements( $statements );
+	}
+
+	/**
+	 * @since 3.0
+	 * 
+	 * @param Statement[]|Traversable
+	 *
+	 * @throws InvalidArgumentException
+	 */
+	public function setStatements( $statements ) {
 		if ( !is_array( $statements ) && !( $statements instanceof Traversable ) ) {
 			throw new InvalidArgumentException( '$statements must be an array or an instance of Traversable' );
 		}
 
+		$this->statements = array();
 		foreach ( $statements as $statement ) {
 			if ( !( $statement instanceof Statement ) ) {
 				throw new InvalidArgumentException( 'Every element in $statements must be an instance of Statement' );

tests/unit/Statement/StatementListTest.php

@@ -666,4 +666,40 @@ public function testGivenInvalidGuid_getFirstStatementWithGuidReturnsNull() {
 		$this->assertNull( $statements->getFirstStatementWithGuid( false ) );
 	}
 
+	public function testGivenEmptyStatementList_setStatementsFillsIt() {
+		$statement1 = $this->getStatement( 1, 'guid1' );
+		$statement2 = $this->getStatement( 2, 'guid2' );
+		$statement3 = $this->getStatement( 3, 'guid3' );
+		$statement4 = $this->getStatement( 2, 'guid5' );
+		$statements = new StatementList();
+
+		$statements->setStatements( array( $statement1, $statement2, $statement3, $statement4 ) );
+		$this->assertEquals(
+			new StatementList( $statement1, $statement2, $statement3, $statement4 ),
+			$statements
+		);
+	}
+
+	public function testGivenFilledStatementList_setStatementsOverridesIt() {
+		$statement1 = $this->getStatement( 1, 'guid1' );
+		$statement2 = $this->getStatement( 2, 'guid2' );
+		$statement3 = $this->getStatement( 3, 'guid3' );
+		$statement4 = $this->getStatement( 2, 'guid5' );
+		$statements = new StatementList( $statement1, $statement2, $statement3, $statement4 );
+
+		$statements->setStatements( array( $statement1, $statement4 ) );
+		$this->assertEquals(
+			new StatementList( $statement1, $statement4 ),
+			$statements
+		);
+	}
+
+	public function testGivenNoTraversable_setStatementsThrowsException() {
+		$statement1 = $this->getStatement( 1, 'guid1' );
+		$statements = new StatementList();
+
+		$this->setExpectedException( 'InvalidArgumentException' );
+		$statements->setStatements( $statement1 );
+	}
+
 }