Skip to content

Commit 404f966

Browse files
committed
Make Item and Property no longer extend Entity
This patch removes the inheritance from Item and Property to Entity. It also removes Entity as it no longer has an implementation in this component and cannot be used or tested now.
1 parent 2850bd7 commit 404f966

6 files changed

Lines changed: 12 additions & 327 deletions

File tree

RELEASE-NOTES.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
# Wikibase DataModel release notes
22

3+
## Version 6.0.0 (dev)
4+
5+
* Removed `Entity` class (deprecated since 1.0)
6+
* `Item` and `Property` no longer extend `Entity`
7+
* Removed `getLabel`, `getLabels`, `getDescription`, `getDescriptions`, `getAliases`,
8+
`getAllAliases`, `setLabels`, `setDescriptions`, `addAliases`, `setAllAliases`,
9+
`removeLabel`, `removeDescription` and `removeAliases` methods
10+
311
## Version 5.1.0 (2016-03-08)
412

513
This release significantly reduces the memory footprint when entities are cloned.

src/Entity/Entity.php

Lines changed: 0 additions & 323 deletions
This file was deleted.

src/Entity/Item.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
use Wikibase\DataModel\Statement\StatementList;
1010
use Wikibase\DataModel\Statement\StatementListHolder;
1111
use Wikibase\DataModel\Term\Fingerprint;
12+
use Wikibase\DataModel\Term\FingerprintHolder;
1213

1314
/**
1415
* Represents a single Wikibase item.
@@ -19,7 +20,7 @@
1920
* @licence GNU GPL v2+
2021
* @author Jeroen De Dauw < jeroendedauw@gmail.com >
2122
*/
22-
class Item extends Entity implements StatementListHolder {
23+
class Item implements EntityDocument, FingerprintHolder, StatementListHolder {
2324

2425
const ENTITY_TYPE = 'item';
2526

src/Entity/Property.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
use Wikibase\DataModel\Statement\StatementList;
77
use Wikibase\DataModel\Statement\StatementListHolder;
88
use Wikibase\DataModel\Term\Fingerprint;
9+
use Wikibase\DataModel\Term\FingerprintHolder;
910

1011
/**
1112
* Represents a single Wikibase property.
@@ -16,7 +17,7 @@
1617
* @licence GNU GPL v2+
1718
* @author Jeroen De Dauw < jeroendedauw@gmail.com >
1819
*/
19-
class Property extends Entity implements StatementListHolder {
20+
class Property implements EntityDocument, FingerprintHolder, StatementListHolder {
2021

2122
const ENTITY_TYPE = 'property';
2223

tests/unit/Entity/ItemTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
/**
2020
* @covers Wikibase\DataModel\Entity\Item
21-
* @covers Wikibase\DataModel\Entity\Entity
2221
*
2322
* @group Wikibase
2423
* @group WikibaseItem

tests/unit/Entity/PropertyTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
/**
2020
* @covers Wikibase\DataModel\Entity\Property
21-
* @covers Wikibase\DataModel\Entity\Entity
2221
*
2322
* @group Wikibase
2423
* @group WikibaseProperty

0 commit comments

Comments
 (0)