Remove unused HashArray::rebuildIndices and indicesAreUpToDate

Author: thiemowmde

src/HashArray.php

@@ -334,49 +334,6 @@ public function removeDuplicates() {
 		}
 	}
 
-	/**
-	 * Returns if the hash indices are up to date.
-	 * For an HashArray with immutable objects this should always be the case.
-	 * For one with mutable objects it's the responsibility of the mutating code
-	 * to keep the indices up to date (see class documentation) and thus possible
-	 * this has not been done since the last update, thus causing a state where
-	 * one or more indices are out of date.
-	 *
-	 * @since 0.4
-	 *
-	 * @return bool
-	 */
-	public function indicesAreUpToDate() {
-		foreach ( $this->offsetHashes as $hash => $offsets ) {
-			$offsets = (array)$offsets;
-
-			foreach ( $offsets as $offset ) {
-				/** @var Hashable[] $this */
-				if ( $this[$offset]->getHash() !== $hash ) {
-					return false;
-				}
-			}
-		}
-
-		return true;
-	}
-
-	/**
-	 * Removes and adds all elements, ensuring the indices are up to date.
-	 *
-	 * @since 0.4
-	 */
-	public function rebuildIndices() {
-		$hashables = iterator_to_array( $this );
-
-		$this->offsetHashes = [];
-
-		foreach ( $hashables as $offset => $hashable ) {
-			$this->offsetUnset( $offset );
-			$this->offsetSet( $offset, $hashable );
-		}
-	}
-
 	/**
 	 * @see ArrayObject::append
 	 *

tests/unit/HashArray/HashArrayWithDuplicatesTest.php

@@ -4,7 +4,6 @@
 
 use Hashable;
 use Wikibase\DataModel\Fixtures\HashArrayElement;
-use Wikibase\DataModel\Fixtures\MutableHashable;
 use Wikibase\DataModel\HashArray;
 
 /**
@@ -117,24 +116,4 @@ public function testGetHash( HashArray $array ) {
 		);
 	}
 
-	/**
-	 * @dataProvider instanceProvider
-	 * @param HashArray $array
-	 */
-	public function testIndicesAreUpToDate( HashArray $array ) {
-		$this->assertInternalType( 'boolean', $array->indicesAreUpToDate() );
-
-		$mutable = new MutableHashable();
-
-		$array->addElement( $mutable );
-
-		$mutable->text = '~[,,_,,]:3';
-
-		$this->assertFalse( $array->indicesAreUpToDate() );
-
-		$array->rebuildIndices();
-
-		$this->assertTrue( $array->indicesAreUpToDate() );
-	}
-
 }

tests/unit/HashArray/HashArrayWithoutDuplicatesTest.php

@@ -3,7 +3,6 @@
 namespace Wikibase\DataModel\Tests\HashArray;
 
 use Wikibase\DataModel\Fixtures\HashArrayElement;
-use Wikibase\DataModel\Fixtures\MutableHashable;
 use Wikibase\DataModel\HashArray;
 
 /**
@@ -114,24 +113,4 @@ public function testGetHash( HashArray $array ) {
 		}
 	}
 
-	/**
-	 * @dataProvider instanceProvider
-	 * @param HashArray $array
-	 */
-	public function testIndicesAreUpToDate( HashArray $array ) {
-		$this->assertInternalType( 'boolean', $array->indicesAreUpToDate() );
-
-		$mutable = new MutableHashable();
-
-		$array->addElement( $mutable );
-
-		$mutable->text = '~[,,_,,]:3';
-
-		$this->assertFalse( $array->indicesAreUpToDate() );
-
-		$array->rebuildIndices();
-
-		$this->assertTrue( $array->indicesAreUpToDate() );
-	}
-
 }