Restore "EntityId: Hard-deprecate Serializable methods"

This reverts change I26ebf9069a (commit 680ec4eafc), restoring change
Id36b2aebd6 (commit 1af704088a); the deprecation warnings we saw in
production should have been fixed by WikibaseMediaInfo change
Ifd87f4c303 (commit 65e2df926f).

Bug: T345856
Change-Id: I189f95cd6a11a2e4a41bc1edd2dcb41a698e0d02

Author: lucaswerkmeister

RELEASE-NOTES.md

@@ -5,7 +5,8 @@
 * Removed support for calling `Statement::addNewReference()` and `StatementList` constructor with a
   single array argument, which was deprecated in `Version 9.6.0 (2021-03-31)`. These should now be
   called with a variadic argument list.
-* Added `__serialize()` and `__unserialize()` methods to the `EntityId` interface.
+* Added `__serialize()` and `__unserialize()` methods to the `EntityId` interface,
+  and deprecated the `serialize()` and `unserialize()` methods.
 * Added native type hints to the `Statement` and `StatementList` classes
 * Added `strict_types=1` to `Statement.php`, `StatementList.php`, and related test files
 * Removed support for repository names in entity IDs (e.g. `foo:Q1234`)

src/Entity/ItemId.php

@@ -71,6 +71,7 @@ public function __serialize(): array {
 	 * @return string
 	 */
 	public function serialize() {
+		wfDeprecated( __METHOD__, '1.41' );
 		return $this->serialization;
 	}
 
@@ -84,6 +85,7 @@ public function __unserialize( array $data ): void {
 	 * @param string $serialized
 	 */
 	public function unserialize( $serialized ) {
+		wfDeprecated( __METHOD__, '1.41' );
 		$array = json_decode( $serialized );
 		$this->serialization = is_array( $array ) ? $array[1] : $serialized;
 		$this->serialization = $this->serialization ?? '';

src/Entity/NumericPropertyId.php

@@ -65,6 +65,7 @@ public function __serialize(): array {
 	 * @return string
 	 */
 	public function serialize() {
+		wfDeprecated( __METHOD__, '1.41' );
 		return $this->serialization;
 	}
 
@@ -78,6 +79,7 @@ public function __unserialize( array $data ): void {
 	 * @param string $serialized
 	 */
 	public function unserialize( $serialized ) {
+		wfDeprecated( __METHOD__, '1.41' );
 		$array = json_decode( $serialized );
 		$this->serialization = is_array( $array ) ? $array[1] : $serialized;
 		$this->serialization = $this->serialization ?? '';

tests/unit/Entity/EntityIdTest.php

@@ -3,6 +3,7 @@
 namespace Wikibase\DataModel\Tests\Entity;
 
 use InvalidArgumentException;
+use MediaWikiUnitTestCase;
 use ReflectionClass;
 use Wikibase\DataModel\Entity\EntityId;
 use Wikibase\DataModel\Entity\ItemId;
@@ -21,7 +22,7 @@
  * @author Jeroen De Dauw < jeroendedauw@gmail.com >
  * @author John Erling Blad < jeblad@gmail.com >
  */
-class EntityIdTest extends \PHPUnit\Framework\TestCase {
+class EntityIdTest extends MediaWikiUnitTestCase {
 
 	public static function instanceProvider() {
 		$ids = [];
@@ -73,6 +74,9 @@ public static function deserializationCompatibilityProvider(): array {
 	 * @dataProvider deserializationCompatibilityProvider
 	 */
 	public function testDeserializationCompatibility( $expected, $serialization ) {
+		if ( str_starts_with( $serialization, 'C:' ) ) {
+			$this->expectDeprecationAndContinue( '/::unserialize/' );
+		}
 		$this->assertEquals(
 			$expected,
 			unserialize( $serialization )

tests/unit/Entity/EntityIdValueTest.php

@@ -3,6 +3,7 @@
 namespace Wikibase\DataModel\Tests\Entity;
 
 use DataValues\IllegalValueException;
+use MediaWikiUnitTestCase;
 use Wikibase\DataModel\Entity\EntityId;
 use Wikibase\DataModel\Entity\EntityIdValue;
 use Wikibase\DataModel\Entity\ItemId;
@@ -20,7 +21,7 @@
  * @author Thiemo Kreuz
  * @author Daniel Kinzler
  */
-class EntityIdValueTest extends \PHPUnit\Framework\TestCase {
+class EntityIdValueTest extends MediaWikiUnitTestCase {
 
 	public function testCanConstruct() {
 		$entityId = new ItemId( 'Q123' );
@@ -160,6 +161,9 @@ public static function provideDeserializationCompatibility() {
 	 * @param EntityIdValue $expected
 	 */
 	public function testDeserializationCompatibility( $serialized, EntityIdValue $expected ) {
+		if ( str_contains( $serialized, 'C:32:"Wikibase\DataModel\Entity\ItemId"' ) ) {
+			$this->expectDeprecationAndContinue( '/::unserialize/' );
+		}
 		$id = unserialize( $serialized );
 
 		$this->assertEquals( $expected, $id );

tests/unit/Entity/ItemIdTest.php

@@ -3,6 +3,7 @@
 namespace Wikibase\DataModel\Tests\Entity;
 
 use InvalidArgumentException;
+use MediaWikiUnitTestCase;
 use Wikibase\DataModel\Entity\ItemId;
 
 /**
@@ -14,7 +15,7 @@
  * @license GPL-2.0-or-later
  * @author Jeroen De Dauw < jeroendedauw@gmail.com >
  */
-class ItemIdTest extends \PHPUnit\Framework\TestCase {
+class ItemIdTest extends MediaWikiUnitTestCase {
 
 	/**
 	 * @dataProvider idSerializationProvider
@@ -86,6 +87,7 @@ public function testGetEntityType() {
 
 	public function testSerialize() {
 		$id = new ItemId( 'Q1' );
+		$this->expectDeprecationAndContinue( '/ItemId::serialize/' );
 		$this->assertSame( 'Q1', $id->serialize() );
 	}
 
@@ -94,6 +96,7 @@ public function testSerialize() {
 	 */
 	public function testUnserialize( $json, $expected ) {
 		$id = new ItemId( 'Q1' );
+		$this->expectDeprecationAndContinue( '/ItemId::unserialize/' );
 		$id->unserialize( $json );
 		$this->assertSame( $expected, $id->getSerialization() );
 	}

tests/unit/Entity/NumericPropertyIdTest.php

@@ -3,6 +3,7 @@
 namespace Wikibase\DataModel\Tests\Entity;
 
 use InvalidArgumentException;
+use MediaWikiUnitTestCase;
 use Wikibase\DataModel\Entity\NumericPropertyId;
 
 /**
@@ -13,7 +14,7 @@
  *
  * @license GPL-2.0-or-later
  */
-class NumericPropertyIdTest extends \PHPUnit\Framework\TestCase {
+class NumericPropertyIdTest extends MediaWikiUnitTestCase {
 
 	/**
 	 * @dataProvider idSerializationProvider
@@ -85,6 +86,7 @@ public function testGetEntityType() {
 
 	public function testSerialize() {
 		$id = new NumericPropertyId( 'P1' );
+		$this->expectDeprecationAndContinue( '/NumericPropertyId::serialize/' );
 		$this->assertSame( 'P1', $id->serialize() );
 	}
 
@@ -93,6 +95,7 @@ public function testSerialize() {
 	 */
 	public function testUnserialize( $json, $expected ) {
 		$id = new NumericPropertyId( 'P1' );
+		$this->expectDeprecationAndContinue( '/NumericPropertyId::unserialize/' );
 		$id->unserialize( $json );
 		$this->assertSame( $expected, $id->getSerialization() );
 	}