Merge pull request #439 from wmde/snakListConstructor

Add SnakList constructor

Author: bekh6ex

src/Snak/SnakList.php

@@ -2,6 +2,8 @@
 
 namespace Wikibase\DataModel\Snak;
 
+use InvalidArgumentException;
+use Traversable;
 use Wikibase\DataModel\HashArray;
 use Wikibase\DataModel\Internal\MapValueHasher;
 
@@ -17,6 +19,21 @@
  */
 class SnakList extends HashArray {
 
+	/**
+	 * @param Snak[]|Traversable $snaks
+	 *
+	 * @throws InvalidArgumentException
+	 */
+	public function __construct( $snaks = [] ) {
+		if ( !is_array( $snaks ) && !( $snaks instanceof Traversable ) ) {
+			throw new InvalidArgumentException( '$snaks must be an array or an instance of Traversable' );
+		}
+
+		foreach ( $snaks as $index => $snak ) {
+			$this->setElement( $index, $snak );
+		}
+	}
+
 	/**
 	 * @see GenericArrayObject::getObjectType
 	 *

tests/unit/HashArray/HashArrayTest.php

@@ -33,7 +33,7 @@ public function instanceProvider() {
 		$instances = [];
 
 		foreach ( $this->constructorProvider() as $args ) {
-			$instances[] = [ new $class( array_key_exists( 0, $args ) ? $args[0] : null ) ];
+			$instances[] = [ new $class( array_key_exists( 0, $args ) ? $args[0] : [] ) ];
 		}
 
 		return $instances;

tests/unit/Snak/SnakListTest.php

@@ -84,6 +84,7 @@ public function invalidConstructorArgumentsProvider() {
 		$id1 = new PropertyId( 'P1' );
 
 		return [
+			[ null ],
 			[ false ],
 			[ 1 ],
 			[ 0.1 ],